-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[TextInput] Add TextInputType.webSearch (#15762) #158323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
e146dbf to
44a06f1
Compare
0c70401 to
0204b9d
Compare
Renzo-Olivares
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ small nits, thanks for the contribution!
victorsanni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for the PR!!
This PR adds the engine part to add `TextInputType.webSearch` that allows to show a keyboard with ready access to a "." key on iOS. On Android this is re-mapped to `url` which shows the same behaviour as `webSearch` on iOS. This fixes issue flutter/flutter#157562. The flutter PR: flutter/flutter#158323
…ne#56428) This PR adds the engine part to add `TextInputType.webSearch` that allows to show a keyboard with ready access to a "." key on iOS. On Android this is re-mapped to `url` which shows the same behaviour as `webSearch` on iOS. This fixes issue flutter#157562. The flutter PR: flutter#158323
This PR adds
TextInputType.webSearchthat allows to show a keyboard with ready access to a "." key on iOS. On Android this is re-mapped tourlwhich shows the same behaviour aswebSearchon iOS. This fixes issue #157562.There also is a corresponding engine PR.
Screenshot from iOS demo app:
Pre-launch Checklist
///).