reimplement Cache.engineRevision using engine-dart-sdk.stamp #158081
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
andrewkolos
force-pushed
the
experiment-with-using-engine-stamp-instead-of-engine-version
branch
4 times, most recently
from
9876e08 to
1184ccd
Compare
9 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
…tructor (#158201) While doing some hacking on `Cache` in #158081, I noticed that [`Cache.test`](https://github.com/flutter/flutter/blob/de9318275391a6d2f10ae33c576f4113b25fd156/packages/flutter_tools/lib/src/cache.dart#L139) allows the caller to tell Cache to use some given directory as the flutter root (instead of depending on the static global [`Cache.flutterRoot`](https://github.com/flutter/flutter/blob/4f3976a4f2b722d26c3353158dcd26590859dde0/packages/flutter_tools/lib/src/cache.dart#L206)). This has a default value, `/cache`. However, `/cache` is an unintuitive name for the root directory of a Flutter installation. This led to confusion when updating some tests. I wanted to create `/bin/cache/engine-dart-sdk.stamp` for tests, but in reality I needed to create `/cache/bin/cache/engine-dart-sdk.stamp`. This PR changes this default to the current directory of the file system (which I'm guessing is `/` for all intents and purposes). <details> <summary> Pre-launch checklist </summary> </details>
andrewkolos
force-pushed
the
experiment-with-using-engine-stamp-instead-of-engine-version
branch
from
b469fca to
71db5d4
Compare
andrewkolos
force-pushed
the
experiment-with-using-engine-stamp-instead-of-engine-version
branch
from
067e754 to
6f739e4
Compare
andrewkolos
force-pushed
the
experiment-with-using-engine-stamp-instead-of-engine-version
branch
from
23756a1 to
a84be69
Compare
…-of-engine-version
…-of-engine-version
andrewkolos
commented
Dec 18, 2024
| expect(visitor.containsNewDepfile, false); | ||
| })); | ||
|
|
||
| test('Non-local engine builds use the engine.version file as an Artifact dependency', () => testbed.run(() { |
Contributor
Author
There was a problem hiding this comment.
This is a testing a caching optimization for builds. This can be restored later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment towards reducing dependence on internal/engine.version
Pre-launch checklist
///).