Skip to content

Conversation

@matanlurey
Copy link
Contributor

Closes #157826.

Like @gmackall I could not find any reference to these, and assume they were boilerplate that was never used (or deleted).

@matanlurey matanlurey requested a review from gmackall November 1, 2024 23:33
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 1, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 2, 2024

auto label is removed for flutter/flutter/158031, due to - The status or check suite Mac_arm64 build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2024
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 2, 2024
@auto-submit auto-submit bot merged commit 8b5ad69 into flutter:master Nov 2, 2024
149 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 4, 2024
flutter/flutter@f86b777...8591d0c

2024-11-04 [email protected] Remove null from flex documentation (flutter/flutter#158086)
2024-11-04 [email protected] Add test for `raw_scrollbar.1.dart` (flutter/flutter#158069)
2024-11-04 [email protected] Add test for `interactive_viewer.constrained.0.dart` (flutter/flutter#158044)
2024-11-03 [email protected] Revert "Add and plumb `useImplicitPubspecResolution` across `flutter_tools`." (flutter/flutter#158076)
2024-11-03 [email protected] Revert "Add a warning/additional handlers for parsing`synthetic-package`." (flutter/flutter#158078)
2024-11-03 [email protected] Fixes typos & spelling error in changelog.md file (flutter/flutter#157438)
2024-11-02 [email protected] Add test for `raw_scrollbar.0.dart` (flutter/flutter#157989)
2024-11-02 [email protected] Roll Flutter Engine from 38b6165f137d to 05cb5d7f7939 (4 revisions) (flutter/flutter#158038)
2024-11-02 [email protected] Roll Flutter Engine from 7dfdcacd8ae4 to 38b6165f137d (5 revisions) (flutter/flutter#158034)
2024-11-02 [email protected] Delete unused references to dev.flutter.plugins.e2e. (flutter/flutter#158031)
2024-11-01 [email protected] Roll Flutter Engine from 7b176f4f25da to 7dfdcacd8ae4 (1 revision) (flutter/flutter#158021)
2024-11-01 [email protected] Roll Flutter Engine from 3a090b46dd35 to 7b176f4f25da (2 revisions) (flutter/flutter#158018)
2024-11-01 [email protected] Make SwiftPM integration tests even MORE idiomatic (flutter/flutter#158014)
2024-11-01 [email protected] Improve consistency of code snippets in basic.dart (flutter/flutter#158015)
2024-11-01 [email protected] Remove unnecessary `kCliAnimationsFeatureName` that is available as `.configSetting`. (flutter/flutter#158013)
2024-11-01 [email protected] Make the SwiftPM integration tests more idiomatic (flutter/flutter#157971)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete or fix unused references to dev.flutter.plugins.e2e

2 participants