Make the SwiftPM integration tests more idiomatic #157971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
matanlurey
approved these changes
Nov 1, 2024
| .childDirectory(platformName) | ||
| .childFile('Podfile') | ||
| .existsSync(), | ||
| isTrue, |
Contributor
There was a problem hiding this comment.
I'd go one step further and use exists (it's used elsewhere in package:flutter_tools):
https://pub.dev/documentation/file_testing/latest/file_testing/exists-constant.html
Member
Author
There was a problem hiding this comment.
TIL! The whitespace changes in this one makes this hard to review, I'll send a follow-up to the follow-up 😂
loic-sharma
added
the
autosubmit
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
Reach peak idiomacy by replacing `expect(file.existsSync(), isTrue)` with `expect(file, exists)`! Follow up to: #157971
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 4, 2024
flutter/flutter@f86b777...8591d0c 2024-11-04 [email protected] Remove null from flex documentation (flutter/flutter#158086) 2024-11-04 [email protected] Add test for `raw_scrollbar.1.dart` (flutter/flutter#158069) 2024-11-04 [email protected] Add test for `interactive_viewer.constrained.0.dart` (flutter/flutter#158044) 2024-11-03 [email protected] Revert "Add and plumb `useImplicitPubspecResolution` across `flutter_tools`." (flutter/flutter#158076) 2024-11-03 [email protected] Revert "Add a warning/additional handlers for parsing`synthetic-package`." (flutter/flutter#158078) 2024-11-03 [email protected] Fixes typos & spelling error in changelog.md file (flutter/flutter#157438) 2024-11-02 [email protected] Add test for `raw_scrollbar.0.dart` (flutter/flutter#157989) 2024-11-02 [email protected] Roll Flutter Engine from 38b6165f137d to 05cb5d7f7939 (4 revisions) (flutter/flutter#158038) 2024-11-02 [email protected] Roll Flutter Engine from 7dfdcacd8ae4 to 38b6165f137d (5 revisions) (flutter/flutter#158034) 2024-11-02 [email protected] Delete unused references to dev.flutter.plugins.e2e. (flutter/flutter#158031) 2024-11-01 [email protected] Roll Flutter Engine from 7b176f4f25da to 7dfdcacd8ae4 (1 revision) (flutter/flutter#158021) 2024-11-01 [email protected] Roll Flutter Engine from 3a090b46dd35 to 7b176f4f25da (2 revisions) (flutter/flutter#158018) 2024-11-01 [email protected] Make SwiftPM integration tests even MORE idiomatic (flutter/flutter#158014) 2024-11-01 [email protected] Improve consistency of code snippets in basic.dart (flutter/flutter#158015) 2024-11-01 [email protected] Remove unnecessary `kCliAnimationsFeatureName` that is available as `.configSetting`. (flutter/flutter#158013) 2024-11-01 [email protected] Make the SwiftPM integration tests more idiomatic (flutter/flutter#157971) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend reviewing with whitespace changes disabled.
Changes:
expect(string.contains('foo'), isTrue)withexpect(string, contains('foo'))try/finallywithaddTearDownFollow-up to: #157482 (comment)