Test presubmit of single threaded skwasm reland. #157967
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Nov 1, 2024
This attempts to reland the single-threaded Skwasm PR: #56206 The main changes here are in the second commit: * We need to actually bundle the `skwasm_st` artifacts in `flutter_web_sdk.zip` * The `locateFile` hack no longer works since emscripten doesn't actually create a worker.js file anymore. So instead, that has been modified to use the `mainScriptUrlOrBlob` module API to do a very similar hack. Note: I did presubmit testing with the framework CI and it appears the pertinent tests pass. See flutter/flutter#157967
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
This attempts to reland the single-threaded Skwasm PR: flutter/engine#56206 The main changes here are in the second commit: * We need to actually bundle the `skwasm_st` artifacts in `flutter_web_sdk.zip` * The `locateFile` hack no longer works since emscripten doesn't actually create a worker.js file anymore. So instead, that has been modified to use the `mainScriptUrlOrBlob` module API to do a very similar hack. Note: I did presubmit testing with the framework CI and it appears the pertinent tests pass. See flutter#157967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.