Add a warning/additional handlers for parsingsynthetic-package.
#157934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
andrewkolos
requested changes
Oct 31, 2024
Contributor
andrewkolos
left a comment
andrewkolos
left a comment
There was a problem hiding this comment.
I have some things I need to intensely review here, but here is some stuff to get started in case that's useful. Otherwise, simply wait for another review from me.
packages/flutter_tools/lib/src/dart/generate_synthetic_packages.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/dart/generate_synthetic_packages.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/lib/src/dart/generate_synthetic_packages.dart
Outdated
Show resolved
Hide resolved
andrewkolos
reviewed
Oct 31, 2024
packages/flutter_tools/test/general.shard/dart/generate_synthetic_packages_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/general.shard/dart/generate_synthetic_packages_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/general.shard/dart/generate_synthetic_packages_test.dart
Outdated
Show resolved
Hide resolved
…tic_packages_test.dart Co-authored-by: Andrew Kolos <[email protected]>
…tic_packages_test.dart Co-authored-by: Andrew Kolos <[email protected]>
…tic_packages_test.dart Co-authored-by: Andrew Kolos <[email protected]>
…s.dart Co-authored-by: Andrew Kolos <[email protected]>
matanlurey
added
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/157934, due to - The status or check suite Linux tool_integration_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 1, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 1, 2024
flutter/flutter@0fe6153...f86b777 2024-11-01 [email protected] Roll Packages from 7cc1caa to 796afa3 (15 revisions) (flutter/flutter#158003) 2024-11-01 [email protected] Marks Linux_pixel_7pro service_extensions_test to be flaky (flutter/flutter#157853) 2024-11-01 [email protected] Roll Flutter Engine from 0a0d5c9be6ff to 3a090b46dd35 (1 revision) (flutter/flutter#157994) 2024-11-01 [email protected] Roll Flutter Engine from bacc5e1e73b7 to 0a0d5c9be6ff (3 revisions) (flutter/flutter#157991) 2024-11-01 [email protected] Add test for `interactive_viewer.transformation_controller.0.dart` (flutter/flutter#157986) 2024-11-01 [email protected] Roll Flutter Engine from d7e928911ac2 to bacc5e1e73b7 (1 revision) (flutter/flutter#157982) 2024-11-01 [email protected] Add test for `notification.0.dart` (flutter/flutter#157909) 2024-11-01 [email protected] performance: Override .elementAt in CachingIterable (flutter/flutter#152477) 2024-11-01 [email protected] Roll Flutter Engine from cd46383cd55e to d7e928911ac2 (4 revisions) (flutter/flutter#157978) 2024-11-01 [email protected] Roll Flutter Engine from bb77cf867aef to cd46383cd55e (11 revisions) (flutter/flutter#157972) 2024-11-01 [email protected] Add a warning/additional handlers for parsing`synthetic-package`. (flutter/flutter#157934) 2024-10-31 [email protected] Roll Flutter Engine from f2154ef3e31c to bb77cf867aef (6 revisions) (flutter/flutter#157960) 2024-10-31 [email protected] Renames `injectBuildTimePluginFilesForWebPlatform` and removes unused named parameter. (flutter/flutter#157944) 2024-10-31 [email protected] [flutter_driver] use mostly public screenshot API. (flutter/flutter#157888) 2024-10-31 [email protected] Made insetPadding configurable for Date Picker Dialog (flutter/flutter#155651) 2024-10-31 [email protected] Fix showSnackBar can't access useMaterial3 from the theme (flutter/flutter#157707) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
Time to revert pull request flutter/flutter/157934 has elapsed. |
Contributor
|
reason for revert: b/377107864 |
auto-submit
bot
removed
the
revert
This was referenced Nov 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
4 tasks
sfshaza2
pushed a commit
to flutter/website
that referenced
this pull request
Jun 20, 2025
Update internationalization documents and gen_l10n example to align with deprecation of synthetic packages. From flutter 3.32.0 [breaking changes](https://docs.flutter.dev/release/breaking-changes/flutter-generate-i10n-source), localized messages are generated into source, not a synthetic package. This PR should be merged in the future stable release. Issues fixed by this PR (if any): - #11765 Relative links: - https://groups.google.com/g/flutter-announce/c/ZWtR2h6QAZk - https://flutter.dev/to/flutter-gen-deprecation - flutter/flutter#102983 - flutter/flutter#157934 ## Presubmit checklist - [ ] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. Co-authored-by: amir14a <[email protected]>
ericwindmill
pushed a commit
to flutter/website
that referenced
this pull request
Jun 24, 2025
Update internationalization documents and gen_l10n example to align with deprecation of synthetic packages. From flutter 3.32.0 [breaking changes](https://docs.flutter.dev/release/breaking-changes/flutter-generate-i10n-source), localized messages are generated into source, not a synthetic package. This PR should be merged in the future stable release. Issues fixed by this PR (if any): - #11765 Relative links: - https://groups.google.com/g/flutter-announce/c/ZWtR2h6QAZk - https://flutter.dev/to/flutter-gen-deprecation - flutter/flutter#102983 - flutter/flutter#157934 ## Presubmit checklist - [ ] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. Co-authored-by: amir14a <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #157928.
Closes #157929.
synthetic-packages: true&&--implicit-pubpsec-resolutionflutter_genwith warning.<no synthetic-packages key>&&--implicit-pubspec-resolutionflutter_genwith warning.synthetic-packages: false&&--implicit-pubpsec-resolutionflutter_gen.synthetic-packages: true&&--no-implicit-pubpsec-resolution<no synthetic-packages key>&&--no-implicit-pubspec-resolutionflutter_gen.synthetic-packages: false&&--no-implicit-pubpsec-resolutionflutter_genwith warning.