Add and plumb useImplicitPubspecResolution across flutter_tools.
#157879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
andrewkolos
reviewed
Oct 30, 2024
andrewkolos
reviewed
Oct 30, 2024
Comment on lines
+137
to
+141
| expect(l10nDirectory.existsSync(), true); | ||
| expect(l10nDirectory.childFile('app_localizations_en.dart').existsSync(), | ||
| true); | ||
| expect( | ||
| l10nDirectory.childFile('app_localizations.dart').existsSync(), true); |
Contributor
There was a problem hiding this comment.
I think using the isTrue matcher instead of true would give a slightly better failure message if any of these expects were to fail.
Contributor
Author
There was a problem hiding this comment.
I think if anything isFalse/isTrue will possibly be deprecated in the future: dart-lang/test#2358.
andrewkolos
reviewed
Oct 30, 2024
Comment on lines
26
to
28
| testUsingContext( | ||
| 'Exits with code 2 when HttpException is thrown ' | ||
| 'during VM service connection', () async { |
Contributor
There was a problem hiding this comment.
Unintentional formatting change
andrewkolos
reviewed
Oct 30, 2024
Comment on lines
38
to
39
| exception: const HttpException( | ||
| 'Connection closed before full header was received, ' |
Contributor
There was a problem hiding this comment.
Unintentional formatting change
andrewkolos
reviewed
Oct 30, 2024
Comment on lines
60
to
63
| final List<FlutterDevice> devices = <FlutterDevice>[ | ||
| flutterDevice1, | ||
| flutterDevice2 | ||
| ]; |
Contributor
There was a problem hiding this comment.
Unintentional formatting change?
andrewkolos
reviewed
Oct 30, 2024
Comment on lines
226
to
229
| }) : super(device, | ||
| buildInfo: BuildInfo.debug, | ||
| generator: generator, | ||
| developmentShaderCompiler: const FakeShaderCompiler()); |
Contributor
There was a problem hiding this comment.
I think there are still unintentional formatting changes in this file
Contributor
I am not terribly worried about this since we won't have this for more than one release |
matanlurey
added
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/157879, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/157879, due to - The status or check suite Linux tool_integration_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 31, 2024
Manual roll requested by [email protected] flutter/flutter@fe71cad...0fe6153 2024-10-31 [email protected] Roll Flutter Engine from c40b0b602822 to f2154ef3e31c (8 revisions) (flutter/flutter#157926) 2024-10-31 [email protected] Hides added routes before top-most route finishes pushing (flutter/flutter#156104) 2024-10-31 [email protected] Fix cursor on hover expand/collapse icon (#155207) (flutter/flutter#155209) 2024-10-31 [email protected] Add test for `media_query_data.system_gesture_insets.0.dart` (flutter/flutter#157854) 2024-10-31 [email protected] Add and plumb `useImplicitPubspecResolution` across `flutter_tools`. (flutter/flutter#157879) 2024-10-31 [email protected] Roll Flutter Engine from 090c33aeae83 to c40b0b602822 (1 revision) (flutter/flutter#157896) 2024-10-31 [email protected] Roll Flutter Engine from 9295eeb6d3ce to 090c33aeae83 (4 revisions) (flutter/flutter#157893) 2024-10-30 [email protected] Roll Flutter Engine from 2bd854e23b61 to 9295eeb6d3ce (5 revisions) (flutter/flutter#157882) 2024-10-30 [email protected] Adds a new helpful tool exit message for SocketExceptions thrown during mdns discovery (flutter/flutter#157638) 2024-10-30 [email protected] Fix `GlowingOverscrollIndicator` examples (flutter/flutter#155203) 2024-10-30 [email protected] Roll Flutter Engine from 906a7ad88052 to 2bd854e23b61 (1 revision) (flutter/flutter#157878) 2024-10-30 [email protected] Upgrade templates to AGP 8.7/Gradle 8.10.2 (flutter/flutter#157872) 2024-10-30 [email protected] Roll Flutter Engine from 57ed5d338e7e to 906a7ad88052 (13 revisions) (flutter/flutter#157875) 2024-10-30 [email protected] Update Material 3 `LinearProgressIndicator` for new visual style (flutter/flutter#154817) 2024-10-30 [email protected] Roll Flutter Engine from 999797a2f690 to 57ed5d338e7e (5 revisions) (flutter/flutter#157833) 2024-10-30 [email protected] Add hidden `--no-implicit-pubspec-resolution` flag for one stable release. (flutter/flutter#157635) 2024-10-30 [email protected] Roll Packages from 028027e to 7cc1caa (5 revisions) (flutter/flutter#157864) 2024-10-30 [email protected] Mention partial PRs in the contributing docs (flutter/flutter#157863) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
Time to revert pull request flutter/flutter/157879 has elapsed. |
auto-submit
bot
removed
the
revert
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #157819. No behavior changes as a result of this PR.
Based on a proof of concept by @jonahwilliams (#157818).
The existence of this flag (which for the time being, defaults to
true) implies the following:The (legacy, deprecated)
.flutter-pluginsfile is not generated:https://docs.flutter.dev/release/breaking-changes/flutter-plugins-configuration
The (legacy, deprecated)
package:flutter_genis not synthetically generated:Declare
package:flutter_gento be deprecated website#11343(awaiting website approvers, but owners approve this change)
This change creates
useImplicitPubspecResolutionand plumbs it through as a required variable, parsing it from aFlutterCommand.globalResultswhere able. In tests, I've defaulted the value totrue100% of the time - except for places where the value itself is acted on directly, in which case there are true and false test-cases (e.g. localization and i10n based classes and functions).I'm not extremely happy this needed to change 50+ files, but is sort of a result of how inter-connected many of the elements of the tools are. I believe keeping this as an explicit (flagged) argument will be our best way to ensure the default behavior changes consistently and that tests are running as expected.