Add test for focus_node.unfocus.0.dart
#157673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
bleroux
reviewed
Oct 28, 2024
Comment on lines
19
to
21
| await tester.tap(find.byType(TextField).first); // Focuses the first text field. | ||
| await tester.pump(); |
Contributor
There was a problem hiding this comment.
Suggested change
| await tester.tap(find.byType(TextField).first); // Focuses the first text field. | |
| await tester.pump(); | |
| // Focuses the first text field. | |
| await tester.tap(find.byType(TextField).first); | |
| await tester.pump(); |
Cosmetic change to use the same commenting approach than below.
bleroux
approved these changes
Oct 28, 2024
Contributor
bleroux
left a comment
bleroux
left a comment
There was a problem hiding this comment.
LGTM! with minor comments
Comment on lines
79
to
87
| expect( | ||
| find.descendant( | ||
| of: find.byType(TextField).first, | ||
| matching: find.byWidgetPredicate( | ||
| (Widget focus) => focus is Focus && (focus.focusNode?.hasFocus ?? false), | ||
| ), | ||
| ), | ||
| findsOne, | ||
| ); |
Contributor
There was a problem hiding this comment.
Not sure it is better, but if you want something shorter, the following is probably ok:
final EditableText firstEditableText = tester.firstWidget(find.byType(EditableText));
expect(firstEditableText.focusNode.hasFocus, true);
Contributor
Author
There was a problem hiding this comment.
Sure ! I changed it in test: Shorter expects
Comment on lines
54
to
50
| await tester.tap(find.byType(TextField).first); // Focuses the first text field. | ||
| await tester.pump(); |
Contributor
There was a problem hiding this comment.
Suggested change
| await tester.tap(find.byType(TextField).first); // Focuses the first text field. | |
| await tester.pump(); | |
| // Focuses the first text field. | |
| await tester.tap(find.byType(TextField).first); | |
| await tester.pump(); |
ValentinVignal
force-pushed
the
flutter/api/example/Add-test-for-focus-node-unfocus
branch
from
a3fa482 to
cdee05f
Compare
ValentinVignal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 28, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 28, 2024
flutter/flutter@5a11904...3fb95c7 2024-10-28 [email protected] Roll Flutter Engine from bf5bfeebf89f to 23b2c6d3b3b1 (3 revisions) (flutter/flutter#157736) 2024-10-28 [email protected] Avoid labeling 'context' PRs as 'text-input' (flutter/flutter#157650) 2024-10-28 [email protected] Add test for `restorable_route_future.0.dart` (flutter/flutter#157708) 2024-10-28 [email protected] Update .ci.yaml have android sdk be 35v1 (flutter/flutter#157621) 2024-10-28 [email protected] Roll Flutter Engine from 2522789c4199 to bf5bfeebf89f (1 revision) (flutter/flutter#157713) 2024-10-28 [email protected] Add test for `restoration_mixin.0.dart` (flutter/flutter#157709) 2024-10-28 [email protected] Add test for `navigator.restorable_push_replacement.0.dart` (flutter/flutter#157704) 2024-10-28 [email protected] Add test for `focus_node.unfocus.0.dart` (flutter/flutter#157673) 2024-10-28 [email protected] Roll Flutter Engine from 9226b089d634 to 2522789c4199 (2 revisions) (flutter/flutter#157710) 2024-10-28 [email protected] Add tests for `navigator_state.restorable_push.0.dart` (flutter/flutter#157667) 2024-10-28 [email protected] Roll Flutter Engine from 10e50bd42c42 to 9226b089d634 (1 revision) (flutter/flutter#157702) 2024-10-28 [email protected] Add test for `navigator_state.restorable_push_replacement.0.dart` (flutter/flutter#157668) 2024-10-28 [email protected] Remove unsafe_html lint rule (flutter/flutter#157531) 2024-10-27 [email protected] Roll Flutter Engine from 3162aaad0086 to 10e50bd42c42 (1 revision) (flutter/flutter#157690) 2024-10-27 [email protected] Fix Scaffold extend body (flutter/flutter#157441) 2024-10-26 [email protected] Roll Flutter Engine from c9b8ac96f6ce to 3162aaad0086 (3 revisions) (flutter/flutter#157681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #130459
It adds a test for
examples/api/lib/widgets/focus_manager/focus_node.unfocus.0.dartPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.