Fix ResizeImage documentation
#157619
Merged
Fix ResizeImage documentation
#157619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
nate-thegrate
commented
Oct 25, 2024
Comment on lines
-1199
to
-1200
| /// Logical pixels have roughly the same visual size across devices, whereas | ||
| /// physical pixels correspond to actual device hardware. |
Contributor
Author
There was a problem hiding this comment.
This sentence (which was written by me) is unnecessarily confusing, since an unconstrained ResizeImage's scaling to match logical pixels means that by default, it doesn't match the resolution of the actual device hardware.
Closed
victorsanni
approved these changes
Oct 30, 2024
Contributor
Author
|
Much appreciated 🫡 |
nate-thegrate
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 30, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 30, 2024
flutter/flutter@42132e8...fe71cad 2024-10-30 [email protected] Update CHANGELOG.md to correct ios vs macos issue (flutter/flutter#157822) 2024-10-30 [email protected] Add ability to customize the default `Slider` padding (flutter/flutter#156143) 2024-10-30 [email protected] Fix menu anchor state handling (flutter/flutter#157612) 2024-10-30 [email protected] Add test for `interactive_viewer.0.dart` (flutter/flutter#157773) 2024-10-30 [email protected] Add test for `scroll_metrics_notification.0.dart` (flutter/flutter#157768) 2024-10-30 [email protected] Add boundary feature to the drag gesture. (flutter/flutter#147521) 2024-10-30 [email protected] Fix `ResizeImage` documentation (flutter/flutter#157619) 2024-10-29 [email protected] Roll Flutter Engine from 795b5492f1b9 to 999797a2f690 (1 revision) (flutter/flutter#157825) 2024-10-29 [email protected] Avoid labeling all PRs as 'text-input' (flutter/flutter#157805) 2024-10-29 [email protected] Roll Packages from e0c4f55 to 028027e (8 revisions) (flutter/flutter#157813) 2024-10-29 [email protected] Roll Flutter Engine from 725c8e4bc379 to 795b5492f1b9 (5 revisions) (flutter/flutter#157820) 2024-10-29 [email protected] Fix and remove a few `no-shuffle` tags in `flutter_tools`. (flutter/flutter#157656) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whoever reviewed the documentation changes in #154212 neglected to double-check that the information was accurate (it was me who did this).
Fixes #136508