Reland "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10" #157617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flutter#157032)" (flutter#157559)" This reverts commit b98d9a3.
github-actions
bot
added
a: tests
github-actions
bot
added
the
a: text input
reidbaker
approved these changes
Oct 29, 2024
gmackall
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 29, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 29, 2024
flutter/flutter@3fb95c7...42132e8 2024-10-29 [email protected] Reland "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10" (flutter/flutter#157617) 2024-10-29 [email protected] [impeller] re-enable impeller shard. (flutter/flutter#157806) 2024-10-29 [email protected] Roll Flutter Engine from 4cb4478016b5 to 725c8e4bc379 (1 revision) (flutter/flutter#157808) 2024-10-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Avoid labeling 'context' PRs as 'text-input' (#157650)" (flutter/flutter#157812) 2024-10-29 [email protected] Roll Flutter Engine from b95da8106b98 to 4cb4478016b5 (1 revision) (flutter/flutter#157792) 2024-10-29 [email protected] Remove unused import from kt plugin template (flutter/flutter#157220) 2024-10-29 [email protected] Roll Flutter Engine from 5fa7a123b14a to b95da8106b98 (1 revision) (flutter/flutter#157787) 2024-10-29 [email protected] Fix `TabBar` tab icons not respecting custom `IconTheme` (flutter/flutter#157724) 2024-10-29 [email protected] Roll Flutter Engine from 0c8f0bf4d740 to 5fa7a123b14a (1 revision) (flutter/flutter#157780) 2024-10-29 [email protected] Allow customizing entry mode icons in TimePicker (flutter/flutter#157151) 2024-10-29 [email protected] Add test for `focus_scope.0.dart` (flutter/flutter#157772) 2024-10-29 [email protected] Add test for `page_storage.0.dart` (flutter/flutter#157770) 2024-10-29 [email protected] Roll Flutter Engine from c05af6f939fc to 0c8f0bf4d740 (1 revision) (flutter/flutter#157774) 2024-10-29 [email protected] Roll Flutter Engine from b394e0c98fa0 to c05af6f939fc (1 revision) (flutter/flutter#157767) 2024-10-29 [email protected] Add test for `nested_scroll_view_state.0.dart` (flutter/flutter#157714) 2024-10-29 [email protected] Pin Mac tool_integration_test shards to arm64 (flutter/flutter#157760) 2024-10-29 [email protected] Roll Flutter Engine from ed587dcf61fd to b394e0c98fa0 (4 revisions) (flutter/flutter#157766) 2024-10-28 [email protected] Roll Flutter Engine from 70671baabbba to ed587dcf61fd (10 revisions) (flutter/flutter#157751) 2024-10-28 [email protected] Roll Flutter Engine from 23b2c6d3b3b1 to 70671baabbba (1 revision) (flutter/flutter#157740) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
9 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
These are the versions we use in test, as of #157617. Motivated by noticing a warning with the old template version: ``` This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = "UpsideDownCakePrivacySandbox"). You are strongly encouraged to update your project to use a newer Android Gradle plugin that has been tested with compileSdk = 35. ```
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland of #157032.
Failed tests for initial land:
https://flutter-dashboard.appspot.com/#/build?hashFilter=5ca6350a06fdae8d3e160f9adbece193f34d0302&repo=flutter&branch=master
These two tests run the same
flavors_testhttps://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20flavors_test/4579/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_mokey%20flavors_test_win/988/overview
which is now passing
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20flavors_test/37/overview
(fixed by 23c62df)
The other failures seem to be flakes
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20new_gallery_impeller_old_zoom__transition_perf/4902/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20tool_integration_tests_2_5/1247/overview
the first is a timeout, the second passed in presubmit on the original PR and also on this PR.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.