Skip to content

Prevent flutter build ios-framework --xcframework from copying Flutter.xcframework.dSYM into the App.framework folder. #157394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Oct 23, 2024
Merged

Prevent flutter build ios-framework --xcframework from copying Flutter.xcframework.dSYM into the App.framework folder. #157394

auto-submit merged 5 commits into from
Oct 23, 2024

Conversation

@LouiseHsu
Copy link
Contributor

@LouiseHsu LouiseHsu commented Oct 22, 2024 •
edited
Loading

Fixes #157359

Prevents Flutter.xcframework.dSYM from being copied into the App.framework folder. I am not 100% positive if there are cases where it's valid to have multiple dSYMs in that folder, so I'm just string matching and filtering out Flutter.xcframework.dSYM

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 22, 2024
@LouiseHsu LouiseHsu changed the title boop dsyms Prevent flutter build ios-framework --xcframework from copying Flutter.xcframework.dSYM into the App.framework folder. Oct 23, 2024
@LouiseHsu LouiseHsu requested a review from jmagman October 23, 2024 18:08
@LouiseHsu LouiseHsu marked this pull request as ready for review October 23, 2024 18:09
jmagman
jmagman reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test that if the module has plugins that their dSYMs are not also added to App.xcframework?
From my steps to reproduce before the xcframework output, run flutter pub add camera or some other plugin.

jmagman
jmagman reviewed Oct 23, 2024
View reviewed changes
@LouiseHsu
Copy link
Contributor Author

LouiseHsu commented Oct 23, 2024

Can you test that if the module has plugins that their dSYMs are not also added to App.xcframework? From my steps to reproduce before the xcframework output, run flutter pub add camera or some other plugin.

I tried adding a couple of plugins and the plugin dSYMs did not get copied in, with or without this fix. So that's good!

jmagman
jmagman reviewed Oct 23, 2024
View reviewed changes
jmagman
jmagman approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 23, 2024
@auto-submit auto-submit bot merged commit bade559 into flutter:master Oct 23, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2024
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
6969751 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2024
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
3b47d37 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2024
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
efa62bf 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2024
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
bcbabee 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
ba1e425 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
643d1e4 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
71d86a6 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
e1b8ed0 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
0b4f716 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 26, 2024
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
f562e25 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 26, 2024
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
38ac61d 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
M97Chahboun pushed a commit to M97Chahboun/flutter that referenced this pull request Oct 30, 2024
@LouiseHsu @M97Chahboun
Prevent flutter build ios-framework --xcframework from copying `Flu…
0b2cdee 
…tter.xcframework.dSYM` into the `App.framework` folder. (flutter#157394)

Fixes flutter#157359

Prevents Flutter.xcframework.dSYM from being copied into the App.framework folder. I am not 100% positive if there are cases where it's valid to have multiple dSYMs in that folder, so I'm just string matching and filtering out `Flutter.xcframework.dSYM`
@LouiseHsu LouiseHsu added the cp: stable cherry pick this pull request to stable release candidate branch label Nov 4, 2024
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Nov 4, 2024
@LouiseHsu
Prevent flutter build ios-framework --xcframework from copying `Flu…
5f20e52 
…tter.xcframework.dSYM` into the `App.framework` folder. (flutter#157394)

Fixes flutter#157359

Prevents Flutter.xcframework.dSYM from being copied into the App.framework folder. I am not 100% positive if there are cases where it's valid to have multiple dSYMs in that folder, so I'm just string matching and filtering out `Flutter.xcframework.dSYM`
@LouiseHsu LouiseHsu added the cp: beta cherry pick this pull request to beta release candidate branch label Nov 4, 2024
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Nov 4, 2024
@LouiseHsu
Prevent flutter build ios-framework --xcframework from copying `Flu…
6d1e4aa 
…tter.xcframework.dSYM` into the `App.framework` folder. (flutter#157394)

Fixes flutter#157359

Prevents Flutter.xcframework.dSYM from being copied into the App.framework folder. I am not 100% positive if there are cases where it's valid to have multiple dSYMs in that folder, so I'm just string matching and filtering out `Flutter.xcframework.dSYM`
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
d7d0406 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
e9a4ece 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
a622209 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
10daf26 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
bade559 Prevent flutter build ios-framework --xcframework from copy…
b93b611 
…ing `Flutter.xcframework.dSYM` into the `App.framework` folder. (flutter/flutter#157394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flutter build ios-framework --xcframework incorrectly copies Flutter.framework.dSYM into App.xcframework

2 participants

@LouiseHsu @jmagman