Skip to content

Conversation

@engine-flutter-autoroll
Copy link
Contributor

flutter/engine@2d3f0f4...50f6d98

2024-10-22 [email protected] [Impeller] refactor clip rendering. (flutter/engine#56030)
2024-10-22 [email protected] Fix macos xcprivacy manifest copy location (flutter/engine#56010)
2024-10-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Copy gen_snapshots using python's shutil.copy, avoid links (#55830)" (flutter/engine#56034)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 22, 2024
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Oct 22, 2024
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #157389 at sha 7d4b8d6

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Oct 22, 2024
@jonahwilliams jonahwilliams merged commit a96dd8b into flutter:master Oct 23, 2024
@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-eb36a16d-e5be-4680-8d1a-e1c33bffaeb2-1729635886 branch October 29, 2024 22:32
M97Chahboun pushed a commit to M97Chahboun/flutter that referenced this pull request Oct 30, 2024
…lutter#157389)

flutter/engine@2d3f0f4...50f6d98

2024-10-22 [email protected] [Impeller] refactor clip rendering.
(flutter/engine#56030)
2024-10-22 [email protected] Fix macos xcprivacy manifest copy location
(flutter/engine#56010)
2024-10-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Copy gen_snapshots using python's shutil.copy, avoid links (flutter#55830)"
(flutter/engine#56034)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App engine flutter/engine related. See also e: labels. will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants