Reverts "Fix TextField selects all content after the application is resumed (#156968)" #157378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
github-actions
bot
added
a: text input
fluttergithubbot
approved these changes
Oct 22, 2024
auto-submit
bot
deleted the
revert_383a221cf31d4d4981344c09f92b7c9956c7d0bc
branch
Contributor
|
@bleroux The failure is:
Any idea why this PR would cause that? Do we need to check |
Contributor
|
It was a bug in the test :-(. Sorry to revert for that reason. We can reland this change exactly as-is now that the test is fixed in the google repo. |
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
…sumed" (#157399) ## Description Relands #156968 wich was reverted in #157378 This PR makes `EditableText` aware of the lifecycle 'resumed' state to let the current selection unchanged when the application is resumed (on web and desktop, 'resumed' means the Flutter app window regained focus). Before this PR, on web and desktop, the whole content of a `TextField` was selected whenever a `TextField` gained focus. This is the correct behavior when tabbing between fields but it is not when a field regains focus after the application is resumed ## Related Issue Fixes [When switching to another browser tab or window and then going back, all text on TextField is selected automatically](#156078). ## Tests Adds 1 test.
Contributor
|
Oh good news, looks like it was already relanded. Thanks! |
M97Chahboun
pushed a commit
to M97Chahboun/flutter
that referenced
this pull request
Oct 30, 2024
…esumed (flutter#156968)" (flutter#157378) Reverts: flutter#156968 Initiated by: jacobsimionato Reason for reverting: Google3 roll failing - see b/375019489 Original PR Author: bleroux Reviewed By: {justinmc, gspencergoog} This change reverts the following previous change: ## Description This PR makes `EditableText` aware of the lifecycle 'resumed' state to let the current selection unchanged when the application is resumed (on web and desktop, 'resumed' means the Flutter app window regained focus). Before this PR, on web and desktop, the whole content of a `TextField` was selected whenever a `TextField` gained focus. This is the correct behavior when tabbing between fields but it is not when a field regains focus after the application is resumed ## Related Issue Fixes [When switching to another browser tab or window and then going back, all text on TextField is selected automatically](flutter#156078). ## Tests Adds 1 test.
M97Chahboun
pushed a commit
to M97Chahboun/flutter
that referenced
this pull request
Oct 30, 2024
…sumed" (flutter#157399) ## Description Relands flutter#156968 wich was reverted in flutter#157378 This PR makes `EditableText` aware of the lifecycle 'resumed' state to let the current selection unchanged when the application is resumed (on web and desktop, 'resumed' means the Flutter app window regained focus). Before this PR, on web and desktop, the whole content of a `TextField` was selected whenever a `TextField` gained focus. This is the correct behavior when tabbing between fields but it is not when a field regains focus after the application is resumed ## Related Issue Fixes [When switching to another browser tab or window and then going back, all text on TextField is selected automatically](flutter#156078). ## Tests Adds 1 test.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
…ion is resumed (#156968)" (flutter/flutter#157378)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…ion is resumed (#156968)" (flutter/flutter#157378)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
…ion is resumed (#156968)" (flutter/flutter#157378)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
…ion is resumed (#156968)" (flutter/flutter#157378)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
…ion is resumed (#156968)" (flutter/flutter#157378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #156968
Initiated by: jacobsimionato
Reason for reverting: Google3 roll failing - see b/375019489
Original PR Author: bleroux
Reviewed By: {justinmc, gspencergoog}
This change reverts the following previous change:
Description
This PR makes
EditableTextaware of the lifecycle 'resumed' state to let the current selection unchanged when the application is resumed (on web and desktop, 'resumed' means the Flutter app window regained focus).Before this PR, on web and desktop, the whole content of a
TextFieldwas selected whenever aTextFieldgained focus. This is the correct behavior when tabbing between fields but it is not when a field regains focus after the application is resumedRelated Issue
Fixes When switching to another browser tab or window and then going back, all text on TextField is selected automatically.
Tests
Adds 1 test.