-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Add example to ClipOval docs #157227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example to ClipOval docs #157227
Conversation
nate-thegrate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I feel inspired to oval-clip my favorite cat photos 🐱
| /// {@tool snippet} | ||
| /// | ||
| /// This example clips an image of a cat using an oval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random observation: there seems to be a 50/50 split regarding whether or not to add an empty line between {@tool snippet} and the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some crazy outliers too:
flutter/packages/flutter/lib/src/material/time_picker.dart
Lines 2967 to 2968 in a775f8a
| /// {@tool snippet} Show a dialog with time unconditionally displayed in 24 hour | |
| /// format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm interesting. The documentation on snippets uses an empty line, I suspect that's the preferred style. I'll do a cleanup pass on this file once my doc PRs land :)
|
(PR triage): @loic-sharma is this ready to merge? |
|
@Piinks Yup, I was keeping these open so that folks could leave feedback. I'll start merging these in. |
Updates `basic.dart` to use consistent doc snippets that follows the style from the [documentation on snippets](https://github.com/flutter/flutter/tree/master/dev/snippets#snippet-tool). Follow-up to: #157227 (comment)
No description provided.