Skip to content

Conversation

@loic-sharma
Copy link
Member

No description provided.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 19, 2024
Copy link
Contributor

@nate-thegrate nate-thegrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I feel inspired to oval-clip my favorite cat photos 🐱

Comment on lines +928 to +930
/// {@tool snippet}
///
/// This example clips an image of a cat using an oval.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random observation: there seems to be a 50/50 split regarding whether or not to add an empty line between {@tool snippet} and the description.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some crazy outliers too:

/// {@tool snippet} Show a dialog with time unconditionally displayed in 24 hour
/// format.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm interesting. The documentation on snippets uses an empty line, I suspect that's the preferred style. I'll do a cleanup pass on this file once my doc PRs land :)

@Piinks
Copy link
Contributor

Piinks commented Oct 22, 2024

(PR triage): @loic-sharma is this ready to merge?

@loic-sharma
Copy link
Member Author

loic-sharma commented Oct 22, 2024

@Piinks Yup, I was keeping these open so that folks could leave feedback. I'll start merging these in.

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 22, 2024
@auto-submit auto-submit bot merged commit bfdb366 into flutter:master Oct 22, 2024
M97Chahboun pushed a commit to M97Chahboun/flutter that referenced this pull request Oct 30, 2024
auto-submit bot pushed a commit that referenced this pull request Nov 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants