Skip to content

Conversation

@koji-1009
Copy link
Contributor

@koji-1009 koji-1009 commented Oct 19, 2024

Remove import as @NonNull is no longer used by #129472.

code

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 19, 2024
@koji-1009 koji-1009 marked this pull request as ready for review October 19, 2024 07:59
@bkonyi bkonyi requested a review from a team October 24, 2024 20:19
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the cleanup

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 24, 2024

auto label is removed for flutter/flutter/157220, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2024
@gmackall gmackall requested a review from a team October 24, 2024 20:35
@koji-1009
Copy link
Contributor Author

Is there anything I can do for the autosubmit label? Thank you.

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 29, 2024
@auto-submit auto-submit bot merged commit 94c5371 into flutter:master Oct 29, 2024
3 checks passed
@koji-1009 koji-1009 deleted the remove/unused_import branch October 29, 2024 15:59
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 29, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 29, 2024
flutter/flutter@3fb95c7...42132e8

2024-10-29 [email protected] Reland "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10" (flutter/flutter#157617)
2024-10-29 [email protected] [impeller] re-enable impeller shard. (flutter/flutter#157806)
2024-10-29 [email protected] Roll Flutter Engine from 4cb4478016b5 to 725c8e4bc379 (1 revision) (flutter/flutter#157808)
2024-10-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Avoid labeling 'context' PRs as 'text-input' (#157650)" (flutter/flutter#157812)
2024-10-29 [email protected] Roll Flutter Engine from b95da8106b98 to 4cb4478016b5 (1 revision) (flutter/flutter#157792)
2024-10-29 [email protected] Remove unused import from kt plugin template (flutter/flutter#157220)
2024-10-29 [email protected] Roll Flutter Engine from 5fa7a123b14a to b95da8106b98 (1 revision) (flutter/flutter#157787)
2024-10-29 [email protected] Fix `TabBar` tab icons not respecting custom `IconTheme` (flutter/flutter#157724)
2024-10-29 [email protected] Roll Flutter Engine from 0c8f0bf4d740 to 5fa7a123b14a (1 revision) (flutter/flutter#157780)
2024-10-29 [email protected] Allow customizing entry mode icons in TimePicker (flutter/flutter#157151)
2024-10-29 [email protected] Add test for `focus_scope.0.dart` (flutter/flutter#157772)
2024-10-29 [email protected] Add test for `page_storage.0.dart` (flutter/flutter#157770)
2024-10-29 [email protected] Roll Flutter Engine from c05af6f939fc to 0c8f0bf4d740 (1 revision) (flutter/flutter#157774)
2024-10-29 [email protected] Roll Flutter Engine from b394e0c98fa0 to c05af6f939fc (1 revision) (flutter/flutter#157767)
2024-10-29 [email protected] Add test for `nested_scroll_view_state.0.dart` (flutter/flutter#157714)
2024-10-29 [email protected] Pin Mac tool_integration_test shards to arm64 (flutter/flutter#157760)
2024-10-29 [email protected] Roll Flutter Engine from ed587dcf61fd to b394e0c98fa0 (4 revisions) (flutter/flutter#157766)
2024-10-28 [email protected] Roll Flutter Engine from 70671baabbba to ed587dcf61fd (10 revisions) (flutter/flutter#157751)
2024-10-28 [email protected] Roll Flutter Engine from 23b2c6d3b3b1 to 70671baabbba (1 revision) (flutter/flutter#157740)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants