Skip to content

Conversation

@nate-thegrate
Copy link
Contributor

Changes

  • Add WidgetStateInputBorder class, with .resolveWith() and .fromMap() constructors
  • Deprecate MaterialStateOutlineInputBorder and MaterialStateUnderlineInputBorder and provide data-driven fixes

Other changes based on #154972 (review)

  • Fix documentation copy-paste typo ("OutlinedBorder" → "InputBorder")
  • Add test to ensure borders are painted correctly
  • Add DartPad sample & relevant test

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos c: tech-debt Technical debt, code quality, testing, etc. labels Oct 18, 2024
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nit!

@nate-thegrate nate-thegrate force-pushed the widgetstate-input-border branch from 723104b to c6dbeb4 Compare October 22, 2024 23:12
@nate-thegrate nate-thegrate added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 22, 2024
@auto-submit auto-submit bot merged commit ea0fda5 into flutter:master Oct 22, 2024
@nate-thegrate nate-thegrate deleted the widgetstate-input-border branch October 25, 2024 20:50
M97Chahboun pushed a commit to M97Chahboun/flutter that referenced this pull request Oct 30, 2024
**Changes**
- Add `WidgetStateInputBorder` class, with `.resolveWith()` and `.fromMap()` constructors
- Deprecate `MaterialStateOutlineInputBorder` and `MaterialStateUnderlineInputBorder` and provide data-driven fixes

<br>

**Other changes** based on flutter#154972 (review)
- Fix documentation copy-paste typo ("OutlinedBorder" � "InputBorder")
- Add test to ensure borders are painted correctly
- Add DartPad sample & relevant test
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: tech-debt Technical debt, code quality, testing, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants