-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Beta test alternate correct macOS framework xcprivacy manifest location #157136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 1 commit into
flutter:flutter-3.27-candidate.0
from
jmagman:privacy-beta
Oct 18, 2024
Merged
Beta test alternate correct macOS framework xcprivacy manifest location #157136
auto-submit
merged 1 commit into
flutter:flutter-3.27-candidate.0
from
jmagman:privacy-beta
Oct 18, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2024
packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart
Show resolved
Hide resolved
christopherfujino
approved these changes
Oct 18, 2024
Contributor
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9 tasks
christopherfujino
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Oct 23, 2024
…on (flutter#157136) The PrivacyInfo.xcprivacy file was originally copied to the top-level macOS framework, but instead needs to be in the Resources directory (which is a different path than iOS). This caused codesigning issues flutter#157016. The path is being corrected flutter/engine#55938 so update the framework test to handle either path. It will be updated to just check the correct path once it rolls into the framework.
M97Chahboun
pushed a commit
to M97Chahboun/flutter
that referenced
this pull request
Oct 30, 2024
…lutter#157318) Cherry-pick the beta branch test flutter#157136 back to master so this doesn't regress in the next beta. This is the framework test for flutter#157016 on master. Engine fix can be merged once this merges.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
tool
Affects the "flutter" command-line tool. See also t: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PrivacyInfo.xcprivacy file was originally copied to the top-level macOS framework, but instead needs to be in the Resources directory (which is a different path than iOS). This caused codesigning issues #157016.
The path is being corrected flutter/engine#55938 so update the framework test to handle either path. It will be updated to just check the correct path once it rolls into the framework.