Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 17, 2024

The PrivacyInfo.xcprivacy file was originally copied to the top-level macOS framework, but instead needs to be in the Resources directory (which is a different path than iOS). This caused codesigning issues #157016.

The path is being corrected flutter/engine#55938 so update the framework test to handle either path. It will be updated to just check the correct path once it rolls into the framework.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 17, 2024
@jmagman jmagman changed the title Test alternate correct macOS framework xcprivacy manifest location Beta test alternate correct macOS framework xcprivacy manifest location Oct 17, 2024
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 18, 2024
@auto-submit auto-submit bot merged commit 077c008 into flutter:flutter-3.27-candidate.0 Oct 18, 2024
@jmagman jmagman deleted the privacy-beta branch October 22, 2024 03:08
auto-submit bot pushed a commit that referenced this pull request Oct 22, 2024
…157318)

Cherry-pick the beta branch test #157136 back to master  so this doesn't regress in the next beta.

This is the framework test for #157016 on master.  Engine fix can be merged once this merges.
@jmagman jmagman added cp: stable cherry pick this pull request to stable release candidate branch and removed cp: stable cherry pick this pull request to stable release candidate branch labels Oct 23, 2024
christopherfujino pushed a commit to flutteractionsbot/flutter that referenced this pull request Oct 23, 2024
…on (flutter#157136)

The PrivacyInfo.xcprivacy file was originally copied to the top-level macOS framework, but instead needs to be in the Resources directory (which is a different path than iOS).  This caused codesigning issues flutter#157016.

The path is being corrected flutter/engine#55938 so update the framework test to handle either path.  It will be updated to just check the correct path once it rolls into the framework.
M97Chahboun pushed a commit to M97Chahboun/flutter that referenced this pull request Oct 30, 2024
…lutter#157318)

Cherry-pick the beta branch test flutter#157136 back to master  so this doesn't regress in the next beta.

This is the framework test for flutter#157016 on master.  Engine fix can be merged once this merges.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants