@stuartmorgan please fill out the PR description above, afterwards the release team will review this request.

@reidbaker @gmackall Thoughts on cherry-picking this to the new beta? It seems like getting this out sooner rather than later will slightly reduce problems overall, and it's low risk, but it's also something that individual developers could do themselves (if they know to).

@reidbaker @gmackall Thoughts on cherry-picking this to the new beta? It seems like getting this out sooner rather than later will slightly reduce problems overall, and it's low risk, but it's also something that individual developers could do themselves (if they know to).

I am for this CP

I agree it is low risk and helpful, which is enough reason for me!

@gmackall can I get you to reformat the change log description to follow these best practices.

https://github.com/flutter/flutter/blob/master/docs/releases/Hotfix-Documentation-Best-Practices.md

In the past this was something a release engineer would do but we are moving to having cherry pickers do it since they have a better understanding of the change.

(or tell me to do it, i can do this one i am just running through the CP's this morning.

@stuartmorgan this cherry-pick has failing tests that did not pass on rerun.

@itsjustkevin Those failures don't look related to the PR (e.g., one is that a hot reload test is expecting a very specific success message and what's being output is a different success message). Are any CPs passing right now?

@stuartmorgan looks like Mac tool_integration_tests_5_5 is also failing on #158131.

@bkonyi I think was looking at failures on that test.

The failure on Mac tool_integration_tests_2_5 has a fix up for review: #158271. I'm looking into the failure on Mac tool_integration_tests_5_5 now.

The failures on Mac tool_integration_tests_5_5 seem to be related to this issue: dart-lang/native#1698.

The failures on Mac tool_integration_tests_5_5 seem to be related to this issue: dart-lang/native#1698.

The check failure from build failure shows in the log

07:29 +31 -1: test/integration.shard/isolated/native_assets_test.dart: flutter build apk succeeds without libraries [E]
  Exception: flutter build failed: 1
  Unhandled exception:
  FormatException: No value was provided for required key: out_dir_shared
  #0      MapJsonUtils.get (package:native_assets_cli/src/json_utils.dart:50:7)
  #1      MapJsonUtils.path (package:native_assets_cli/src/json_utils.dart:25:48)
  #2      new HookConfig (package:native_assets_cli/src/config.dart:88:38)
  #3      new BuildConfig (package:native_assets_cli/src/config.dart)
  #4      build (package:native_assets_cli/src/api/build.dart:99:18)
  #5      main (file:///Volumes/Work/s/w/ir/x/t/pZaMJY/package_with_native_assets/hook/build.dart:4:9)
  #6      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:295:33)
  #7      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)
  Building native assets for package:package_with_native_assets failed.

The root cause for this is if the test uses newest package:native_assets_cli instead of a fixed version (so CI isn't hermetic/deterministic, tests can change results if something got uploaded to pub - which happend in this case) - the new 0.9.0 version of package:native_asset_cli can only be used from 3a83e43 onwards.

The offending code

  final ProcessResult result2 = await processManager.run(
    <String>[
      flutterBin,
      'pub',
      'add',
      'native_assets_cli',
    ],
    workingDirectory: packageDirectory.path,
  );
  expect(result2, const ProcessResultMatcher());

=> This was a problem in the test
=> I believe @matanlurey fix in cc90a42 resolved this

@reidbaker @bkonyi You may need to cherr-pick cc90a42.

Iff the cherry-picks to branches also include updating pub dependencies (i.e. updated via flutter upgrade-packages on the branch - especially if package:logging is upgraded), then you may also want to cherry-pick another fix to native asset tests, namely 31c1292