Skip to content

Conversation

@flutteractionsbot
Copy link

@flutteractionsbot flutteractionsbot commented Oct 16, 2024

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#156758 (comment)

Changelog Description:

Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples

CocoaPods does not work properly with Xcode 16 currently, so this change adds a warning to the tool to provide a work around.

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

None.

Workaround:

Is there a workaround for this issue?

This change adds a warning to the tool which links to workaround steps

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

…w test/watch/extension/other target with Xcode 16 (flutter#156758)

Running `pod install` on Xcode projects with new test/targets in Xcode 16 will fail. Since this is a [Cocoapods bug](CocoaPods/CocoaPods#12456), this PR adds a warning to the tool that links to a github work around and the current tracking issue.

Fixes flutter#156733
<img width="567" alt="Screenshot 2024-10-14 at 14 48 39" src="https://github.com/user-attachments/assets/6befa601-4041-46fc-9ca2-f57662adda4a">
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Oct 16, 2024
@flutteractionsbot
Copy link
Author

@LouiseHsu please fill out the PR description above, afterwards the release team will review this request.

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels Oct 16, 2024
@bkonyi bkonyi requested a review from jmagman October 17, 2024 20:37
@itsjustkevin itsjustkevin added cp: approved Approved cherry-pick request autosubmit Merge PR when tree becomes green via auto submit App labels Nov 5, 2024
@auto-submit auto-submit bot merged commit 274d63e into flutter:flutter-3.26-candidate.0 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop autosubmit Merge PR when tree becomes green via auto submit App cp: approved Approved cherry-pick request cp: review Cherry-picks in the review queue tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants