Add test for animated list example #156452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
bleroux
approved these changes
Oct 9, 2024
Contributor
bleroux
left a comment
bleroux
left a comment
There was a problem hiding this comment.
LGTM! Great test addition, thanks! 🙏
(Two very minor nits before merging).
| expect(find.text('Item 1'), findsOne); | ||
| expect(find.text('Item 2'), findsOne); | ||
|
|
||
| // Add an item at the end of the list |
Contributor
There was a problem hiding this comment.
Suggested change
| // Add an item at the end of the list | |
| // Add an item at the end of the list. |
Contributor
Author
There was a problem hiding this comment.
I've updated them in test: Add test for animated list example :)
| await tester.tap(find.text('Item 1')); | ||
| await tester.pumpAndSettle(); | ||
|
|
||
| // Add item at the top of the list |
Contributor
There was a problem hiding this comment.
Suggested change
| // Add item at the top of the list | |
| // Add item at the top of the list. |
ValentinVignal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 10, 2024
flutter/flutter@2d45fb3...6790525 2024-10-10 [email protected] Roll Packages from 9d00fb1 to f1a3da2 (5 revisions) (flutter/flutter#156538) 2024-10-10 [email protected] Update Android plugin templates for newer AGP (flutter/flutter#156533) 2024-10-10 [email protected] Flutter templates example app Gradle memory settings (flutter/flutter#156201) 2024-10-10 [email protected] Roll Flutter Engine from 3a95d6e1ddbf to 590babc1581b (1 revision) (flutter/flutter#156498) 2024-10-10 [email protected] [canvaskit] Unskip cupertino datepicker tests (flutter/flutter#156499) 2024-10-10 [email protected] Add test for animated list example (flutter/flutter#156452) 2024-10-09 [email protected] Roll Flutter Engine from fb0b59d9438b to 3a95d6e1ddbf (1 revision) (flutter/flutter#156492) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #130459
It adds a test for
examples/api/lib/widgets/animated_list/animated_list.0.dartPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.