Skip to content

integration_test: migrate to build.gradle.kts #156291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Oct 17, 2024
Merged

integration_test: migrate to build.gradle.kts #156291

auto-submit merged 2 commits into from
Oct 17, 2024

Conversation

@bartekpacia
Copy link
Member

@bartekpacia bartekpacia commented Oct 6, 2024

This PR is yet another attempt (after #154125) to reland #142008.

Benefit: this will be the first plugin in Flutter repo that uses Gradle KTS for Android buildscripts. Once it works fine, we can follow up with migration of more plugins later.

The previous error message was:

e: /b/s/w/ir/cache/gradle/caches/jars-8/42139b5be0c79e133a7b5c5c5d5bf731/gradle-7.3.1.jar!/com/android/build/gradle/LibraryExtension.class: Class 'com/android/build/gradle/LibraryExtension' was compiled with an incompatible version of Kotlin. The binary version of its bytecode is unknown, expected version is 1.0.3
e: /b/s/w/ir/cache/gradle/caches/jars-8/043c0d54e2c1bb39208ec4477607cdf5/gradle-api-7.3.1.jar!/com/android/build/api/dsl/LibraryVariantDimension.class: Class 'com/android/build/api/dsl/LibraryVariantDimension' was compiled with an incompatible version of Kotlin. The binary version of its bytecode is unknown, expected version is 1.0.3

FAILURE: Build failed with an exception.

* Where:
Build file '/b/s/w/ir/x/w/flutter/packages/integration_test/android/build.gradle.kts' line: 36

* What went wrong:
com.android.build.gradle.LibraryExtension.setNamespace(Ljava/lang/String;)V

The integration_test plugin now puts com.android.tools.build:gradle:8.1.0 on its classpath since #153795.

This makes me take an optimistic bet that it won't kill the autoroller now 🤞

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Oct 6, 2024
@bartekpacia
Copy link
Member Author

bartekpacia commented Oct 8, 2024 •
edited
Loading

@reidbaker

I made a mistake with the previous PR #154125 - I reverted it before letting all CI to finish running. So now I know this causes tree to break, but I don't really know much more. dashboard link

I'm thinking of merging it, letting it run to the finish (likely marking the tree red), then reverting and knowing what exactly fails, submit the final version.

@reidbaker
Copy link
Contributor

reidbaker commented Oct 8, 2024

I am about to head to vacation. @gmackall will need to make this decision.

@gmackall
Copy link
Member

gmackall commented Oct 8, 2024

The tests should still run after the revert. The postsubmits will generally all run, regardless of future commits (unlike presubmits which cancel when you push a new commit)

@bartekpacia
Copy link
Member Author

bartekpacia commented Oct 9, 2024 •
edited
Loading

Thanks for explaining @gmackall.

In that case, all of the the failing postsubmit tests for the previous version of this PR (#154125) appear to be flakes.

I'm curious wdyt and what course of action would you suggest me to take

@gmackall
Copy link
Member

gmackall commented Oct 17, 2024

Thanks for explaining @gmackall.

In that case, all of the the failing postsubmit tests for the previous version of this PR (#154125) appear to be flakes.

I'm curious wdyt and what course of action would you suggest me to take

Sorry for the late reply - if all the post submit failures were flakes (which they do look like at first glance to me) then I would just reland the original pr with no changes

@bartekpacia bartekpacia requested a review from gmackall October 17, 2024 17:09
@bartekpacia bartekpacia marked this pull request as ready for review October 17, 2024 17:09
@bartekpacia
Copy link
Member Author

bartekpacia commented Oct 17, 2024

thanks @gmackall

let's do this then

@bartekpacia bartekpacia added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 17, 2024
@auto-submit auto-submit bot merged commit 117bb47 into flutter:master Oct 17, 2024
@bartekpacia bartekpacia deleted the integration_test_build_gradle_kts branch October 17, 2024 18:33
@bartekpacia bartekpacia mentioned this pull request Oct 18, 2024
Merged
9 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
117bb47 integration_test: migrate to build.gradle.kts (flutter/flutte…
90070d7 
…r#156291)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
117bb47 integration_test: migrate to build.gradle.kts (flutter/flutte…
0c4f331 
…r#156291)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
117bb47 integration_test: migrate to build.gradle.kts (flutter/flutte…
4cbcb22 
…r#156291)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
117bb47 integration_test: migrate to build.gradle.kts (flutter/flutte…
ef766c0 
…r#156291)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
117bb47 integration_test: migrate to build.gradle.kts (flutter/flutte…
4febae6 
…r#156291)
github-merge-queue bot pushed a commit that referenced this pull request Mar 18, 2025
@bartekpacia
integration_test example Android app: migrate to Gradle KTS (#157193)
7efef42 
After this PR is merged, all of `integration_test` Android gradle
buildscripts will be in Kotlin.

Follow-up of #156291

Part of ongoing effort to use Gradle Kotlin DSL a bit more

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@bartekpacia @romanejaquez
integration_test example Android app: migrate to Gradle KTS (flutter#…
faf0fd8 
…157193)

After this PR is merged, all of `integration_test` Android gradle
buildscripts will be in Kotlin.

Follow-up of flutter#156291

Part of ongoing effort to use Gradle Kotlin DSL a bit more

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmackall gmackall gmackall approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bartekpacia @reidbaker @gmackall