-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Add ability to customize the default Slider padding
#156143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bleroux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! with nits.
1e378ea to
e4d8715
Compare
e4d8715 to
3cec062
Compare
|
The Google testing failures here were not related to this PR, but were caused by an issue that meant the tests did not actually run. So, there may still be failures, rebasing should kick off a new test run. |
3cec062 to
2a4ce33
Compare
2a4ce33 to
1c907d8
Compare
QuncCccccc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this really looks good to me! Next time I should check google testing earlier:)
1c907d8 to
973fec9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:) Thanks for adding it! Do you think if it's worth to add padding property to Slider class?
9f5605e to
7f71fc6
Compare
7f71fc6 to
6827950
Compare
Thank you for the reminder! |
flutter/flutter@42132e8...fe71cad 2024-10-30 [email protected] Update CHANGELOG.md to correct ios vs macos issue (flutter/flutter#157822) 2024-10-30 [email protected] Add ability to customize the default `Slider` padding (flutter/flutter#156143) 2024-10-30 [email protected] Fix menu anchor state handling (flutter/flutter#157612) 2024-10-30 [email protected] Add test for `interactive_viewer.0.dart` (flutter/flutter#157773) 2024-10-30 [email protected] Add test for `scroll_metrics_notification.0.dart` (flutter/flutter#157768) 2024-10-30 [email protected] Add boundary feature to the drag gesture. (flutter/flutter#147521) 2024-10-30 [email protected] Fix `ResizeImage` documentation (flutter/flutter#157619) 2024-10-29 [email protected] Roll Flutter Engine from 795b5492f1b9 to 999797a2f690 (1 revision) (flutter/flutter#157825) 2024-10-29 [email protected] Avoid labeling all PRs as 'text-input' (flutter/flutter#157805) 2024-10-29 [email protected] Roll Packages from e0c4f55 to 028027e (8 revisions) (flutter/flutter#157813) 2024-10-29 [email protected] Roll Flutter Engine from 725c8e4bc379 to 795b5492f1b9 (5 revisions) (flutter/flutter#157820) 2024-10-29 [email protected] Fix and remove a few `no-shuffle` tags in `flutter_tools`. (flutter/flutter#157656) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes Ability to change Sliders padding
Add ability to override default padding so the Slider can fit better in a layout.
Code sample
expand to view the code sample
Before
(Cannot adjust default
Sliderpadding to fill the horizontal space in aColumnand reduce the padded height)After
Can adjust default
Sliderpadding viaSliderTheme)Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.