-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Scribe gestures #156020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Scribe gestures #156020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently I have a hacked version of OverflowBox that does the same thing. Need to modify it to allow the margin to overflow.
I can draw outside of the bounds nicely, but receiving gestures is another story. The parent will stop hit testing when it sees that an event is outside of its boundaries, so I can never receive it. Instead, maybe I should first look into the hover icon. How will I do that?
Contributor
Author
|
This has been updated now that #148784 is merged, but still requires some cleanup. This is on my list of things to get to this quarter. |
Before the monorepo change, this work was done in this PR: flutter/engine#55568
Contributor
Author
|
This PR has been updated with the engine changes originally written in flutter/engine#55568. Predictive back work is taking priority over this for now. |
Contributor
|
Closing to return to in a later PR, confirmed with @justinmc 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: text input
Entering text in a text field or keyboard related problems
engine
flutter/engine related. See also e: labels.
framework
flutter/packages/flutter repository. See also f: labels.
platform-android
Android applications specifically
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Android Scribe stylus handwriting gestures.
This PR may be further split into separate gestures and separate previewing.
Initial Scribe PR: #148784.
And initial Scribe engine PR: flutter/engine#55568.
Fixes #156018.