Skip to content

Reland TabBarTheme normalization #155969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Oct 1, 2024
Merged

Reland TabBarTheme normalization #155969

auto-submit merged 3 commits into from
Oct 1, 2024

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Sep 30, 2024

Reland #155476 with test fix.

The test fix uses the method mentioned in #155476 (comment).

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 30, 2024
TahaTesser
TahaTesser approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 1, 2024
@auto-submit auto-submit bot merged commit 33d3e4b into flutter:master Oct 1, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
92a89bc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
0b694cd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
b615ac3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
993635c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
0a35e89
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
6087746
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
1c55fa5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
8240b9b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
42990ee
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
e9ad4dd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
8108a40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
ad2c0f4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
97b6b0a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
e4258d4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
b6e2757
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
9250791
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
393a89c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 6, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
15ad988
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 6, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
3f7c1d0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
7ba58c6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
99450b8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
33d3e4b Reland TabBarTheme normalization (flutter/flutter#155969)
fc77b0b
@wolfenrain wolfenrain mentioned this pull request Apr 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc @TahaTesser