[CP-stable] Bump package:dds from version 4.2.4+1 to 4.2.4+2 #155789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
bkonyi
approved these changes
Sep 27, 2024
itsjustkevin
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 24, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP Issue: #155837
Hopefully resolves the majority of the remaining
RPCErrorcrashes occurring on stable (context: #153471).Context and what is happening here
Verifying this change
Unfortunately, I have not found a way to reproduce this particular crash (neither organically or inorganically through code modification). I am still decently confident this will fix any of the crashes (from #153471) that include
_withErrorHandlingin their stack trace.However, we can at least be confident that this shouldn't break anything new. The code change is very small.
The easiest way to check what code is being changed here is to
git diffthe version of package:dds we are bumping from and the one we are bumping to:git diff /Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+1/ /Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+2. While I accidentally chose the incorrect base commit when creating 4.2.4+2, the dart code changes should still be minimal:full diff (your IDE probably has a "diff" language mode to make this human-readable)
diff --git a/Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+1/CHANGELOG.md b/Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+2/CHANGELOG.md index a515f931cc..72cd187fbc 100644 --- a/Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+1/CHANGELOG.md +++ b/Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+2/CHANGELOG.md @@ -1,3 +1,7 @@ +# 4.2.4+2 +- [DAP] Fixed an issue where "Service connection disposed" errors may go unhandled during termination/shutdown.Uint8List` from `dart:typed_data`. +- Added `package:dds/dds_launcher.dart`, a library which can be used to launch DDS instances using `dart development-service`. + # 4.2.4+1 - Added missing type to `Event` in `postEvent`. - [DAP] Instaces with both fields and getters of the same name will no longer show duplicates in `variables` responses. @@ -310,8 +314,8 @@ Hot-fix release of changes in 3.1.2 without the changes in 3.1.1 # 1.7.0 - Added `package:dds/vm_service_extensions.dart`, which adds DDS functionality to `package:vm_service` when imported. - - Added `onEventWithHistory` method and `onLoggingEventWithHistory`, - `onStdoutEventWithHistory`, `onStderrEventWithHistory`, and + - Added `onEventWithHistory` method and `onLoggingEventWithHistory`, + `onStdoutEventWithHistory`, `onStderrEventWithHistory`, and `onExtensionEventWithHistory` getters. - Added `getStreamHistory` RPC. diff --git a/Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+1/CONTRIBUTING.md b/Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+2/CONTRIBUTING.md index ddad214772..de7603b2f2 100644 --- a/Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+1/CONTRIBUTING.md +++ b/Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+2/CONTRIBUTING.md @@ -22,6 +22,14 @@ Then you can call `_fileLog('some print debugging message')`, and the log messag To get logging output in real time, run `tail -f /tmp/dds.log`. +## Running DDS tests + +From the `$DART_SDK_ROOT` directory, run: + +```shell + dart --packages=.dart_tool/package_config.json pkg/dds/test/path/to/your_test.dart +``` + ## Making changes to `package:dds` and `package:devtools_shared` **If you do not need to build the Dart SDK** to test your changes, you @@ -38,7 +46,7 @@ dependency_overrides: to adding the dependency override above, you will need to add a symbolic link to your local `devtools_shared` directory: -From the `sdk/` directory, run: +From the `$DART_SDK_ROOT` directory, run: ```shell rm -rf third_party/devtools/devtools_shared; ln -s /absolute_path_to/devtools/packages/devtools_shared third_party/devtools/devtools_shared @@ -51,3 +59,42 @@ To delete the symbolic link after you are done with development, run: ```shell rm -rf third_party/devtools/devtools_shared ``` + +## Making changes to `package:dds` and `devtools_app` + +To test any changes made in `devtools_app`, you will need to first build DevTools. + +- If you have not already, make sure to [set-up your DevTools development environment](https://github.com/flutter/devtools/blob/master/CONTRIBUTING.md#set-up-your-devtools-environment) so that you can use the `devtools_tool` command. + +- Then build DevTools with `devtools_tool build`. + +In the SDK, add a symbolic link to your local `devtools/packages/devtools_app/build/web` directory. + +From the `$DART_SDK_ROOT` directory, run: + +```shell +rm -rf third_party/devtools/web; +ln -s /absolute_path_to/devtools/devtools/packages/devtools_app/build/web third_party/devtools/web +``` + +**WARNING**: do not run `gclient sync -D` while the symbolic link is present, +as this could cause issues with your local `devtools_app` code. + +Then, build the Dart SDK. + +From the `$DART_SDK_ROOT` directory, run: + +```shell +./tools/build.py -mrelease -ax64 create_sdk +``` + +To delete the symbolic link after you are done with development, run: + +**WARNING**: do not run `gclient sync -D` while the symbolic link is present, +as this could cause issues with your local `devtools_app` code. + +```shell +rm -rf third_party/devtools/web +``` + +Then, run `gclient sync` to pull down the checked in version of DevTools. diff --git a/Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+1/lib/src/dap/adapters/dart.dart b/Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+2/lib/src/dap/adapters/dart.dart index 51228f24be..1a0a1f6287 100644 --- a/Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+1/lib/src/dap/adapters/dart.dart +++ b/Users/andrewkolos/.pub-cache/hosted/pub.dev/dds-4.2.4+2/lib/src/dap/adapters/dart.dart @@ -2845,7 +2845,8 @@ abstract class DartDebugAdapter- A library used to spawn the Dart Developer Service, used to communicate with a Dart VM Service instance.You might have notice this extraneous change in particular:
This is is from dart-lang/sdk@5641607. As you can see, there is already a
stderr.closecall in the finally block, so this change is just a refactor and safe to be in this cherry-pick.Pre-launch Checklist
///).