reduce warnings inside flutter.groovy file #2 #155628

AbdeMohlbi · 2024-09-24T20:43:44Z

follow up for : #152073

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-09-24T20:43:47Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

reidbaker · 2024-09-25T14:20:15Z

test-exempt: Gradle files do not have unit tests and this pr is not worth the maintenance burden of a specific integration test covering just this change. Additionally the code being modified is tested under an integration test for native assets and regular app builds.

reidbaker · 2024-09-25T14:24:16Z

Deprecated here https://docs.gradle.org/current/dsl/org.gradle.api.Project.html#org.gradle.api.Project:buildDir
Replacement usage defined here
https://docs.gradle.org/current/dsl/org.gradle.api.file.ProjectLayout.html#org.gradle.api.file.ProjectLayout:buildDirectory

auto-submit · 2024-09-25T14:25:15Z

auto label is removed for flutter/flutter/155628, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

reidbaker · 2024-09-25T14:41:24Z

Also the new codepath has been available since gradle 4.1 https://docs.gradle.org/4.1/javadoc/org/gradle/api/file/ProjectLayout.html

Which is older than the error version of gradle defined here

flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts

Line 92 in 4d1f086

val errorGradleVersion: Version = Version(7, 0, 2)

gmackall

lgtm, thanks!

…/flutter#155628)

follow up for : [flutter#152073](flutter#152073)

…/flutter#155628)

flutter/flutter@538e742...fa402c8 2024-09-26 [email protected] Roll Flutter Engine from 6328a0597b68 to 9e6133e8d906 (1 revision) (flutter/flutter#155762) 2024-09-26 [email protected] Roll Packages from 7da2374 to f38b780 (2 revisions) (flutter/flutter#155760) 2024-09-26 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.1 to 4.5.0 (flutter/flutter#150229) 2024-09-26 [email protected] Roll Flutter Engine from 08f935236e45 to 6328a0597b68 (1 revision) (flutter/flutter#155750) 2024-09-26 [email protected] Roll Flutter Engine from 3a520a2a4399 to 08f935236e45 (1 revision) (flutter/flutter#155748) 2024-09-26 [email protected] Reland "[flutter_tools] Cleanup of native asset related code (removes around 50% of the native asset related code) (#155430)" (flutter/flutter#155745) 2024-09-26 [email protected] Roll Flutter Engine from 896208ee5828 to 3a520a2a4399 (1 revision) (flutter/flutter#155744) 2024-09-26 [email protected] Roll Flutter Engine from fc6c85292b57 to 896208ee5828 (2 revisions) (flutter/flutter#155743) 2024-09-26 [email protected] Roll Flutter Engine from 3719454a879f to fc6c85292b57 (1 revision) (flutter/flutter#155738) 2024-09-26 [email protected] added ability to configure shadow in banner (flutter/flutter#155296) 2024-09-26 [email protected] Roll Flutter Engine from d4850c1ae648 to 3719454a879f (1 revision) (flutter/flutter#155736) 2024-09-26 [email protected] Roll Flutter Engine from d6d5fdba6ae1 to d4850c1ae648 (18 revisions) (flutter/flutter#155733) 2024-09-25 [email protected] Move the Linux runner into a subdirectory (flutter/flutter#153812) 2024-09-25 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.7 to 4.2.0 (flutter/flutter#155711) 2024-09-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[flutter_tools] Cleanup of native asset related code (removes around 50% of the native asset related code) (#155430)" (flutter/flutter#155713) 2024-09-25 [email protected] [flutter_tools] Cleanup of native asset related code (removes around 50% of the native asset related code) (flutter/flutter#155430) 2024-09-25 [email protected] reduce warnings inside flutter.groovy file #2 (flutter/flutter#155628) 2024-09-25 [email protected] [Android] Update `SystemUiMode` and `setSystemChromeEnabledSystemUIMode ` docs to note targeting Android 15+ change (flutter/flutter#153466) 2024-09-25 [email protected] mark linux packages autoroller bringup: true (flutter/flutter#155705) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…155039) The nativeAssetDir is not flavor specific and it should only be added to the jniLibs.scrDir once. Fixes #155038 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

…/flutter#155628)

Update flutter.groovy

59923ea

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 24, 2024

AbdeMohlbi added 8 commits September 24, 2024 22:22

++

3a213d1

++

52aa8a9

++

a79ad06

Update flutter.groovy

8300ba8

++

a9bd8a2

++

5b35133

++

31ac99c

Update flutter.groovy

2f0f2b5

reidbaker requested review from gmackall and reidbaker September 25, 2024 14:15

reidbaker approved these changes Sep 25, 2024

View reviewed changes

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 25, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 25, 2024

gmackall approved these changes Sep 25, 2024

View reviewed changes

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 25, 2024

auto-submit bot merged commit 936cfb8 into flutter:master Sep 25, 2024

engine-flutter-autoroll mentioned this pull request Sep 26, 2024

Roll Flutter from 538e7424d018 to 49873fd23606 (17 revisions) flutter/packages#7710

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2024

936cfb8 reduce warnings inside flutter.groovy file flutter#2 (flutter…

ccf796a

…/flutter#155628)

thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 26, 2024

reduce warnings inside flutter.groovy file flutter#2 (flutter#155628)

29cf306

follow up for : [flutter#152073](flutter#152073)

engine-flutter-autoroll mentioned this pull request Sep 26, 2024

Roll Flutter from 538e7424d018 to 7ec6083bed3b (18 revisions) flutter/packages#7711

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2024

936cfb8 reduce warnings inside flutter.groovy file flutter#2 (flutter…

164ffb9

…/flutter#155628)

engine-flutter-autoroll mentioned this pull request Sep 26, 2024

Roll Flutter from 538e7424d018 to fa402c8057a1 (19 revisions) flutter/packages#7713

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2024

936cfb8 reduce warnings inside flutter.groovy file flutter#2 (flutter…

48f7b06

…/flutter#155628)

engine-flutter-autoroll mentioned this pull request Sep 26, 2024

Roll Flutter from 538e7424d018 to 20bc0a9cb8df (21 revisions) flutter/packages#7715

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2024

936cfb8 reduce warnings inside flutter.groovy file flutter#2 (flutter…

ef2edf8

…/flutter#155628)

engine-flutter-autoroll mentioned this pull request Sep 26, 2024

Roll Flutter from 538e7424d018 to feb9c592840a (22 revisions) flutter/packages#7717

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2024

936cfb8 reduce warnings inside flutter.groovy file flutter#2 (flutter…

e170654

…/flutter#155628)

AbdeMohlbi mentioned this pull request Oct 10, 2024

fix OutputFile deprecation inside flutter.groovy #156490

Closed

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

936cfb8 reduce warnings inside flutter.groovy file flutter#2 (flutter…

206815d

…/flutter#155628)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

936cfb8 reduce warnings inside flutter.groovy file flutter#2 (flutter…

bcd226f

…/flutter#155628)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

reduce warnings inside flutter.groovy file #2 #155628

reduce warnings inside flutter.groovy file #2 #155628

Uh oh!

AbdeMohlbi commented Sep 24, 2024 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Sep 24, 2024

Uh oh!

reidbaker commented Sep 25, 2024 •

edited

Loading

Uh oh!

reidbaker commented Sep 25, 2024

Uh oh!

auto-submit bot commented Sep 25, 2024

Uh oh!

reidbaker commented Sep 25, 2024 •

edited

Loading

Uh oh!

gmackall left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

reduce warnings inside flutter.groovy file #2 #155628

reduce warnings inside flutter.groovy file #2 #155628

Uh oh!

Conversation

AbdeMohlbi commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Sep 24, 2024

Uh oh!

reidbaker commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reidbaker commented Sep 25, 2024

Uh oh!

auto-submit bot commented Sep 25, 2024

Uh oh!

reidbaker commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AbdeMohlbi commented Sep 24, 2024 •

edited

Loading

reidbaker commented Sep 25, 2024 •

edited

Loading

reidbaker commented Sep 25, 2024 •

edited

Loading