[CP-stable]Assert macOS framework artifact contains xcprivacy manifest #155556

flutteractionsbot · 2024-09-23T18:13:52Z

This is the framework-side test for flutter/engine#55366. This test will fail unless it is run on a roll containing that fix.

Issue Link:

#154915

Changelog Description:

Test that a built macOS app contains the FlutterMacOS framework privacy manifest and validates flutter/engine#55366.

Impact Description:

Adds confidence the Flutter macOS engine framework contains the expected privacy manifest at the right path.

Workaround:

N/A

Risk:

What is the risk level of this cherry-pick?

Low
Medium
High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

Yes
No

Validation Steps:

Run the flutter_tool tests

…155189) Add tool test to validate a built macOS app contains the FlutterMacOS framework xcprivacy manifest. Blocked on flutter/engine#55078 rolling in.

flutteractionsbot · 2024-09-23T18:13:54Z

@jmagman please fill out the PR description above, afterwards the release team will review this request.

itsjustkevin · 2024-10-16T15:59:53Z

@jmagman is this cherry-pick request still relevant?

christopherfujino · 2024-10-16T17:20:07Z

@jmagman is this cherry-pick request still relevant?

Yes, I will follow up on it.

jmagman

The path is actually incorrect and it was caught during beta codesigning #157016

This should be updated to #157136

Let's hold off on this stable PR until we confirm that framework test is passing on the beta branch.

reidbaker · 2024-10-23T13:55:30Z

Not taking this for the hotfix release. Please message me if that is incorrect and we need to work to get this pr landed.

christopherfujino · 2024-10-23T18:40:30Z

I am closing this as I believe this is obsolete and we already merged: 077c008 to the 3.27 branch.

christopherfujino · 2024-10-23T18:41:14Z

I am closing this as I believe this is obsolete and we already merged: 077c008 to the 3.27 branch.

Whoops, I got mixed up, this is to 3.24

…on (flutter#157136) The PrivacyInfo.xcprivacy file was originally copied to the top-level macOS framework, but instead needs to be in the Resources directory (which is a different path than iOS). This caused codesigning issues flutter#157016. The path is being corrected flutter/engine#55938 so update the framework test to handle either path. It will be updated to just check the correct path once it rolls into the framework.

christopherfujino · 2024-10-23T18:46:47Z

packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart

+      // the correct location is Versions/A/Resources/PrivacyInfo.xcprivacy.
+      // TODO(jmagman): Switch expectation to only check Resources/ once the new path rolls.
+      // https://github.com/flutter/flutter/issues/157016#issuecomment-2420786225
+      final File topLevelPrivacy =  outputFlutterFramework.childFile('PrivacyInfo.xcprivacy');


WDYT @jmagman?

Perfect, thank you!

auto-submit · 2024-10-23T18:54:19Z

auto label is removed for flutter/flutter/155556, due to - The status or check suite Mac_arm64 tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

christopherfujino · 2024-10-23T18:58:50Z

I'm confused by the test output of the failing test, however, it occurs that we will probably have to roll the engine this PR, or roll the engine into the upstream branch and then rebase this PR, until the updated test will pass.

jmagman · 2024-10-23T21:55:09Z

I'm confused by the test output of the failing test, however, it occurs that we will probably have to roll the engine this PR, or roll the engine into the upstream branch and then rebase this PR, until the updated test will pass.

Oh right, the privacy manifest doesn't exist at all in the engine in stable. The engine roll should happen first.

### Issue Link: flutter/flutter#154915 ### Changelog Description: Comply with the new Apple privacy manifest policy for the macOS Flutter engine framework and prevent the "Missing privacy manifest" warning when submitting a macOS app to the App Store. ### Impact Description: The macOS App Store will start enforcing privacy manifests for third-party SDKs starting November 12, 2024. This change adds an empty privacy manifest to the Flutter engine FlutterMacOS.framework to comply with this new policy and prevents the warning. ### Workaround: Add an empty PrivacyInfo.xcprivacy plist to FlutterMacOS.framework and re-codesign it manually. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? A test was added to the framework, which should also be cherry-picked flutter/flutter#155556. While we can confirm the expected file is present, only a TestFlight/App Store submission will confirm the warning is gone. ### Validation Steps: Submit a Flutter macOS app to TestFlight or the App Store. Confirm there is no submission warning email sent.

reidbaker · 2024-10-24T14:14:23Z

bin/internal/engine.version

I updated this to include flutter/engine#56059

Oh and post submits passed.

…4aef0ba03929a0e6de65e0951f

cbracken

nice!

christopherfujino · 2024-10-24T17:03:33Z

LGTM

…cy manifest (flutter/flutter#155556)

### Issue Link: flutter/flutter#154915 ### Changelog Description: Comply with the new Apple privacy manifest policy for the macOS Flutter engine framework and prevent the "Missing privacy manifest" warning when submitting a macOS app to the App Store. ### Impact Description: The macOS App Store will start enforcing privacy manifests for third-party SDKs starting November 12, 2024. This change adds an empty privacy manifest to the Flutter engine FlutterMacOS.framework to comply with this new policy and prevents the warning. ### Workaround: Add an empty PrivacyInfo.xcprivacy plist to FlutterMacOS.framework and re-codesign it manually. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? A test was added to the framework, which should also be cherry-picked flutter/flutter#155556. While we can confirm the expected file is present, only a TestFlight/App Store submission will confirm the warning is gone. ### Validation Steps: Submit a Flutter macOS app to TestFlight or the App Store. Confirm there is no submission warning email sent.

Assert macOS framework artifact contains xcprivacy manifest (flutter#…

1fa49e6

…155189) Add tool test to validate a built macOS app contains the FlutterMacOS framework xcprivacy manifest. Blocked on flutter/engine#55078 rolling in.

flutteractionsbot added the cp: review Cherry-picks in the review queue label Sep 23, 2024

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 23, 2024

jmagman mentioned this pull request Sep 23, 2024

[CP-stable]Add xcprivacy privacy manifest to macOS framework flutter/engine#55366

Merged

5 tasks

jmagman requested changes Oct 18, 2024

View reviewed changes

christopherfujino closed this Oct 23, 2024

christopherfujino reopened this Oct 23, 2024

christopherfujino reviewed Oct 23, 2024

View reviewed changes

jmagman approved these changes Oct 23, 2024

View reviewed changes

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 23, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 23, 2024

Update engine.version to include flutter/engine#56059

6268d97

github-actions bot added the engine flutter/engine related. See also e: labels. label Oct 24, 2024

reidbaker approved these changes Oct 24, 2024

View reviewed changes

Merge branch 'flutter-3.24-candidate.0' into cp-stable-8a07265a88eecb…

c51acc6

…4aef0ba03929a0e6de65e0951f

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2024

auto-submit bot merged commit 6031040 into flutter:flutter-3.24-candidate.0 Oct 24, 2024

cbracken reviewed Oct 24, 2024

View reviewed changes

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2024

603104015 [CP-stable]Assert macOS framework artifact contains xcpriva…

18cd74b

…cy manifest (flutter/flutter#155556)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024

603104015 [CP-stable]Assert macOS framework artifact contains xcpriva…

08e22ed

…cy manifest (flutter/flutter#155556)

[CP-stable]Assert macOS framework artifact contains xcprivacy manifest #155556

[CP-stable]Assert macOS framework artifact contains xcprivacy manifest #155556

Uh oh!

Conversation

flutteractionsbot commented Sep 23, 2024 • edited by jmagman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Link:

Changelog Description:

Impact Description:

Workaround:

Risk:

Test Coverage:

Validation Steps:

Uh oh!

flutteractionsbot commented Sep 23, 2024

Uh oh!

itsjustkevin commented Oct 16, 2024

Uh oh!

christopherfujino commented Oct 16, 2024

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

reidbaker commented Oct 23, 2024

Uh oh!

christopherfujino commented Oct 23, 2024

Uh oh!

christopherfujino commented Oct 23, 2024

Uh oh!

christopherfujino Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

jmagman Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Oct 23, 2024

Uh oh!

christopherfujino commented Oct 23, 2024

Uh oh!

jmagman commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reidbaker Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

reidbaker Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Oct 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

flutteractionsbot commented Sep 23, 2024 •

edited by jmagman

Loading

jmagman commented Oct 23, 2024 •

edited

Loading