Update README.md #155206
Merged
Update README.md #155206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
nate-thegrate
left a comment
nate-thegrate
left a comment
There was a problem hiding this comment.
If you're good with reverting the "the", I'd be happy to approve a 1-word change!
Contributor
|
Looks like you'll also need to sign the CLA, per the comment above. |
Contributor
Author
thank you very much. |
Contributor
Author
I have already signed the CLA. |
nate-thegrate
approved these changes
Sep 16, 2024
Member
|
To me as a non-native English speaker, what's the difference? |
mit-mit
approved these changes
Sep 20, 2024
nate-thegrate
added
the
autosubmit
Contributor
Sorry @bartekpacia, didn't notice this comment till now! The word "that" is used to create an essential clause, whereas "which" is used for making a non-essential clause. The fact that Skia underpins Chrome and Android is good to know, but it could be removed from the sentence and you'd still be able to get the point across. |
Member
|
Had no idea about this concept – TIL. Thanks! :) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 21, 2024
flutter/flutter@7fe8237...2f149da 2024-09-20 [email protected] Update README.md (flutter/flutter#155206) 2024-09-20 [email protected] Roll Flutter Engine from 3fbe87c088d3 to 76b7abb5c853 (3 revisions) (flutter/flutter#155464) 2024-09-20 [email protected] Roll Packages from d83d021 to f54fe93 (1 revision) (flutter/flutter#155459) 2024-09-20 [email protected] Roll Flutter Engine from f5310c2345cc to 3fbe87c088d3 (1 revision) (flutter/flutter#155440) 2024-09-20 [email protected] Roll Flutter Engine from 730f7124213f to f5310c2345cc (1 revision) (flutter/flutter#155436) 2024-09-20 [email protected] Roll Flutter Engine from 90630957b33e to 730f7124213f (1 revision) (flutter/flutter#155431) 2024-09-19 [email protected] Roll Flutter Engine from d8ac05c3fb4f to 90630957b33e (1 revision) (flutter/flutter#155428) 2024-09-19 [email protected] Roll Flutter Engine from 0ed8af4d6e5d to d8ac05c3fb4f (2 revisions) (flutter/flutter#155425) 2024-09-19 [email protected] Roll Packages from c7406b3 to d83d021 (3 revisions) (flutter/flutter#155421) 2024-09-19 [email protected] Roll Flutter Engine from 1d889dd5acac to 0ed8af4d6e5d (1 revision) (flutter/flutter#155419) 2024-09-19 [email protected] Roll Flutter Engine from af3e63a638f7 to 1d889dd5acac (1 revision) (flutter/flutter#155397) 2024-09-19 [email protected] Roll Flutter Engine from bc7d519a332c to af3e63a638f7 (1 revision) (flutter/flutter#155389) 2024-09-19 [email protected] Roll Flutter Engine from fe823a93f631 to bc7d519a332c (1 revision) (flutter/flutter#155387) 2024-09-19 [email protected] Roll Flutter Engine from 94f852d2348c to fe823a93f631 (5 revisions) (flutter/flutter#155385) 2024-09-19 [email protected] Roll Flutter Engine from 15e9e3153266 to 94f852d2348c (2 revisions) (flutter/flutter#155376) 2024-09-19 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 7.0.2 to 7.0.5 (flutter/flutter#155378) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
This PR changes > libraries like Skia (that underpins Chrome and Android) to: > libraries like Skia (which underpins Chrome and Android)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
to: