Implement CupertinoSearchTextField opacity fade on scroll #155025
Conversation
github-actions
bot
added
framework
|
Works only on mobile platforms... Maybe something to do with |
| void didChangeDependencies() { | ||
| super.didChangeDependencies(); | ||
| _ancestorScrollController?.removeListener(_onScroll); | ||
| _ancestorScrollController = Scrollable.maybeOf(context)?.widget.controller; |
There was a problem hiding this comment.
This is probably why it is only working on mobile.
ScrollableState.widget.controller will only have a controller if the user has provided one, or the ancestor ScrollView decided to assign the PrimaryScrollController.
See the _effectiveScrollController in ScrollableState, which accounts for this. It may need to be made public for this feature, although, you could use ScrollableState.position and listen to that alternatively. :)
| } | ||
|
|
||
| void _onScroll() { | ||
| if (_ancestorScrollPosition == null) { |
There was a problem hiding this comment.
You should check if the pixels property can be used, with hasPixels. The scroll position might not be attached.
I'm wondering if the snapping effect is more of a nav bar thing rather than a widget specific thing. Because in the settings app for instance, the padding/margin around the search bar also snaps along with the search bar itself. If we implement the snapping on the widget level, how would that play with the snapping on the nav bar level? |
| } | ||
|
|
||
| void _onScroll() { | ||
| if (_ancestorScrollPosition == null || !_ancestorScrollPosition!.hasPixels) { |
There was a problem hiding this comment.
Today we talked about setting _maxHeight here when _onScroll is called for the first time by looking up the render object as you are below. 👍
There was a problem hiding this comment.
In that case, we may want to use the ScrollNotificationObserver. It would be more consistent with how the AppBar scrolledUnder behavior works, and we could get more information about what kind of scrolling is occurring.
MitchellGoodwin
left a comment
MitchellGoodwin
left a comment
There was a problem hiding this comment.
Code LGTM, but I'm not very informed on scrolling.
For the snapping on partial scroll: it makes an amount of sense to have that in a separate PR. Maybe with the drawer/ bottom work? But I'm just wondering if anything about this PR may get in the way of that. Is there a rough idea of how that could be implemented?
I don't think this PR will get in the way of that. For the snapping/autoscrolling, I think we can grab the ScrollController of the parent CustomScrollView, and animate the scroll by the necessary offset when we receive a ScrollEndNotification (and the title/bottom is partially scrolled under the edge of the viewport). This would probably be in its own PR. |
victorsanni
added
the
autosubmit
5 participants
Before:
364571986-9d3c59a3-5fda-47b2-993b-cc05b9eba596.1.mov
After:
Screen.Recording.2024-09-11.at.9.37.41.AM.mov
Native iOS:
364571955-39372e3d-e59a-43c7-a94b-b71038b1ee6e.mov
Fixes #154648
Needed for #18103
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.