text button case rework #154943
Merged
text button case rework #154943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
a: text input
DBowen33
force-pushed
the
text-button-case-rework
branch
from
65f4e09 to
89eb7fd
Compare
DBowen33
force-pushed
the
text-button-case-rework
branch
from
89eb7fd to
4ce1e30
Compare
nate-thegrate
approved these changes
Sep 13, 2024
Contributor
nate-thegrate
left a comment
nate-thegrate
left a comment
There was a problem hiding this comment.
LGTM, pending a bunch of tiny nits 🙂
Thanks very much for the improvement!
Co-authored-by: Nate Wilson <[email protected]>
Co-authored-by: Nate Wilson <[email protected]>
Co-authored-by: Nate Wilson <[email protected]>
Co-authored-by: Nate Wilson <[email protected]>
Co-authored-by: Nate Wilson <[email protected]>
Co-authored-by: Nate Wilson <[email protected]>
DBowen33
added
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/154943, due to - The status or check suite Windows build_tests_1_7 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
nate-thegrate
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 17, 2024
flutter/flutter@2d30fe4...5d83a98 2024-09-14 [email protected] Roll Flutter Engine from c83cc8856282 to 622d4aec2e04 (1 revision) (flutter/flutter#155202) 2024-09-14 [email protected] Roll Flutter Engine from 4d8d8517a0ff to c83cc8856282 (3 revisions) (flutter/flutter#155201) 2024-09-14 [email protected] Roll Flutter Engine from ab9daaa0bcc7 to 4d8d8517a0ff (12 revisions) (flutter/flutter#155194) 2024-09-13 [email protected] text button case rework (flutter/flutter#154943) 2024-09-13 [email protected] Roll Flutter Engine from bef48e87f438 to ab9daaa0bcc7 (3 revisions) (flutter/flutter#155172) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework on the text button use case to pass b/347102786,
After talking with the tester, it seems like there isn't an issue with the A11y of the text button, rather just how the test case is set up. In order for the text case to pass, there needs to be real time feedback of an action that is done by pressing the text button (think of a dialog popup, or form submission notification).
So I rewrote the test case to mimic a simple form with a submit button that once submitted, will let the user know it is submitted with a snack bar notification. https://screencast.googleplex.com/cast/NTM0ODc1NDIxMDE2MDY0MHwzYWI4MTZhMS1hMA
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.