Skip to content

Revert "Improve CupertinoPopupSurface appearance" #154893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkwingsmt merged 2 commits into from
Sep 10, 2024
Merged

Revert "Improve CupertinoPopupSurface appearance" #154893

dkwingsmt merged 2 commits into from
Sep 10, 2024

Conversation

@davidhicks980
Copy link
Contributor

@davidhicks980 davidhicks980 commented Sep 10, 2024 •
edited
Loading

Reverts #151430 to fix #154887 until I can investigate further.

@dkwingsmt

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Sep 10, 2024
@davidhicks980 davidhicks980 marked this pull request as ready for review September 10, 2024 01:39
dkwingsmt
dkwingsmt approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Renzo-Olivares
Renzo-Olivares approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt dkwingsmt merged commit bffa215 into flutter:master Sep 10, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
2d03921 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
c72475e 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
d8a45b7 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
ff79c02 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
6aa55a0 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
bd0deb2 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
6a48566 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
5220af7 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
4f0c39b 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
4c5f8f1 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
f3c8d1f 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
683feb7 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
edc8b41 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
6ee3240 
…utter#154893)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
10b0c24 
…utter#154893)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
f652a30 
…utter#154893)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
d0dafae 
…utter#154893)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
bffa215 Revert "Improve CupertinoPopupSurface appearance" (flutter/fl…
288a629 
…utter#154893)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CupertinoAlertDialog fading in/out leaves a temporary black square

3 participants

@davidhicks980 @Renzo-Olivares @dkwingsmt