Delete packages/flutter_tools/lib/src/fuchsia directory #154880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
github-actions
bot
added
the
a: text input
zijiehe-google-com
changed the title
chingjun
approved these changes
Sep 16, 2024
Contributor
chingjun
left a comment
chingjun
left a comment
There was a problem hiding this comment.
Thanks for the cleanup. LGTM with a nit.
Also cc @christopherfujino @bkonyi
| ? FuchsiaApp.fromFuchsiaProject(FlutterProject.current().fuchsia) | ||
| : FuchsiaApp.fromPrebuiltApp(applicationBinary); | ||
| // Unsupported yet. | ||
| return null; |
Contributor
There was a problem hiding this comment.
Maybe throw UnimplementedError() here?
Contributor
There was a problem hiding this comment.
This LGTM if you apply this suggestion
christopherfujino
added
autosubmit
Contributor
|
@chingjun actually, I'm thinking we can/should also delete the |
Contributor
Author
|
fuchsia does use flutter/engine, not very sure if the .ci.yaml file being referred above is relevant. |
Contributor
|
@zijiehe-google-com do you know whether fuchsia is using flutter/engine prebuilts? Or is it built in the fuchsia tree? Note that this is not directly related to this PR, and we can take the discussion offline / internal if you prefer so. |
Contributor
Author
|
The pre built binaries from flutter/engine. |
Contributor
Author
|
I will follow up with you offline. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 18, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 19, 2024
Manual roll requested by [email protected] flutter/flutter@c4c9f47...7fe8237 2024-09-18 [email protected] Roll Flutter Engine from 4bdcbf39c200 to 15e9e3153266 (1 revision) (flutter/flutter#155371) 2024-09-18 [email protected] Roll Flutter Engine from fdf38910bad4 to 4bdcbf39c200 (5 revisions) (flutter/flutter#155368) 2024-09-18 [email protected] Roll Packages from 4f2b9cd to c7406b3 (1 revision) (flutter/flutter#155362) 2024-09-18 [email protected] Roll Flutter Engine from 4f2d866aef32 to fdf38910bad4 (1 revision) (flutter/flutter#155339) 2024-09-18 [email protected] Roll Flutter Engine from 311ba971bb3a to 4f2d866aef32 (4 revisions) (flutter/flutter#155329) 2024-09-18 [email protected] Fix missing icon props in button `styleFrom` methods (flutter/flutter#154821) 2024-09-17 [email protected] Roll Flutter Engine from 0ef18a3ef064 to 311ba971bb3a (8 revisions) (flutter/flutter#155325) 2024-09-17 [email protected] [CupertinoAlertDialog] Add tap-slide gesture (flutter/flutter#154853) 2024-09-17 [email protected] Uninstall /can fail/ (flutter/flutter#155314) 2024-09-17 [email protected] Roll Packages from df88c81 to 4f2b9cd (3 revisions) (flutter/flutter#155312) 2024-09-17 [email protected] Roll Flutter Engine from a1700b9ea2db to 0ef18a3ef064 (1 revision) (flutter/flutter#155311) 2024-09-17 [email protected] Roll Flutter Engine from 1376288f5c2a to a1700b9ea2db (2 revisions) (flutter/flutter#155290) 2024-09-17 [email protected] Delete packages/flutter_tools/lib/src/fuchsia directory (flutter/flutter#154880) 2024-09-17 [email protected] Adds ColorSwatch matcher (flutter/flutter#155272) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not being actively used, and fuchsia team does not have bandwidth to maintain it.
Bug: https://b.corp.google.com/issues/353729557
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.