Skip to content

Fix leaky tests. #154847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Sep 9, 2024
Merged

Fix leaky tests. #154847

auto-submit merged 1 commit into from
Sep 9, 2024

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Sep 9, 2024

No description provided.

@polina-c polina-c requested a review from chunhtai September 9, 2024 19:48
@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 9, 2024
chunhtai
chunhtai approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/test/widgets/heroes_test.dart
),
);
final HeroController controller = HeroController();
addTearDown(controller.dispose);
Copy link
Contributor

@chunhtai chunhtai Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why doesn't this fail before?

Copy link
Contributor Author

@polina-c polina-c Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It failed, but the bots are not blocking yet. This is proposal in progress: http://flutter.dev/go/leak-tracker-make-bots-blocking

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 9, 2024
@auto-submit auto-submit bot merged commit 8435e12 into flutter:master Sep 9, 2024
@polina-c polina-c deleted the fix1 branch September 9, 2024 22:33
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
8de2c93
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
0081ce8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
3484081
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
252f7ad
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
416211c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
29301ab
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
6738ed8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
cb8c982
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
030b158
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
60f88af
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
8a1f3e4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
816d40c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
a2ffe30
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
0f1c5e2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
5a399b7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
35df77c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
6ddcd10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
72f3e36
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
8435e12 Fix leaky tests. (flutter/flutter#154847)
b8ec3f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polina-c @chunhtai