Fix missing icon props in button `styleFrom` methods #154821

TahaTesser · 2024-09-09T13:58:38Z

Fixes Add missing icon props in button styleFrom methods.

Description

Add missing icon propers in the following widgets:

ElevatedButton.styleFrom (missing iconSize)
FilledButton.styleFrom (missing iconSize)
OutlinedButton.styleFrom (missing iconSize)
TextButton.styleFrom (missing iconSize)
MenuItemButton.styleFrom (missing iconSize and disabledIconColor)
SubmenuButton.styleFrom (missing iconSize and disabledIconColor)
SegmentedButton.styleFrom (missing iconSize, iconColor, and disabledIconColor)

Code sample

expand to view the code sample

import 'package:flutter/material.dart';

enum Calendar { day, week, month, year }

void main() => runApp(const MyApp());

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  Calendar calendarView = Calendar.week;
  bool isEnabled = true;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Center(
          child: Column(
            spacing: 10.0,
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              ElevatedButton.icon(
                style: ElevatedButton.styleFrom(
                  iconSize: 30,
                  iconColor: Colors.red,
                  disabledIconColor: Colors.red.withValues(alpha: 0.5),
                ),
                onPressed: isEnabled ? () {} : null,
                icon: const Icon(Icons.add),
                label: const Text('ElevatedButton'),
              ),
              FilledButton.icon(
                style: ElevatedButton.styleFrom(
                  iconSize: 30,
                  iconColor: Colors.red,
                  disabledIconColor: Colors.red.withValues(alpha: 0.5),
                ),
                onPressed: isEnabled ? () {} : null,
                icon: const Icon(Icons.add),
                label: const Text('FilledButton'),
              ),
              FilledButton.tonalIcon(
                style: ElevatedButton.styleFrom(
                  iconSize: 30,
                  iconColor: Colors.red,
                  disabledIconColor: Colors.red.withValues(alpha: 0.5),
                ),
                onPressed: isEnabled ? () {} : null,
                icon: const Icon(Icons.add),
                label: const Text('Add'),
              ),
              OutlinedButton.icon(
                style: ElevatedButton.styleFrom(
                  iconSize: 30,
                  iconColor: Colors.red,
                  disabledIconColor: Colors.red.withValues(alpha: 0.5),
                ),
                onPressed: isEnabled ? () {} : null,
                icon: const Icon(Icons.add),
                label: const Text('OutlinedButton'),
              ),
              TextButton.icon(
                style: ElevatedButton.styleFrom(
                  iconSize: 30,
                  iconColor: Colors.red,
                  disabledIconColor: Colors.red.withValues(alpha: 0.5),
                ),
                onPressed: isEnabled ? () {} : null,
                icon: const Icon(Icons.add),
                label: const Text('TextButton'),
              ),
              SizedBox(
                width: 200,
                child: MenuItemButton(
                  style: MenuItemButton.styleFrom(
                    iconSize: 30,
                    iconColor: Colors.red,
                    disabledIconColor: Colors.red.withValues(alpha: 0.5),
                  ),
                  trailingIcon: const Icon(Icons.arrow_forward_ios),
                  onPressed: isEnabled ? () {} : null,
                  child: const Text('MenuItemButton'),
                ),
              ),
              SizedBox(
                width: 200,
                child: SubmenuButton(
                  style: SubmenuButton.styleFrom(
                    iconSize: 30,
                    iconColor: Colors.red,
                    disabledIconColor: Colors.red.withValues(alpha: 0.5),
                  ),
                  trailingIcon: const Icon(Icons.arrow_forward_ios),
                  menuChildren: <Widget>[
                    if (isEnabled) const Text('Item'),
                  ],
                  child: const Text('SubmenuButton'),
                ),
              ),
              SegmentedButton<Calendar>(
                style: SegmentedButton.styleFrom(
                  iconColor: Colors.red,
                  iconSize: 30,
                  disabledIconColor: Colors.red.withValues(alpha: 0.5),
                ),
                segments: const <ButtonSegment<Calendar>>[
                  ButtonSegment<Calendar>(
                      value: Calendar.day,
                      label: Text('Day'),
                      icon: Icon(Icons.calendar_view_day)),
                  ButtonSegment<Calendar>(
                      value: Calendar.week,
                      label: Text('Week'),
                      icon: Icon(Icons.calendar_view_week)),
                  ButtonSegment<Calendar>(
                      value: Calendar.month,
                      label: Text('Month'),
                      icon: Icon(Icons.calendar_view_month)),
                  ButtonSegment<Calendar>(
                      value: Calendar.year,
                      label: Text('Year'),
                      icon: Icon(Icons.calendar_today)),
                ],
                selected: <Calendar>{calendarView},
                onSelectionChanged:
                    isEnabled ? (Set<Calendar> newSelection) {} : null,
              )
            ],
          ),
        ),
        floatingActionButton: FloatingActionButton.extended(
          onPressed: () {
            setState(() {
              isEnabled = !isEnabled;
            });
          },
          label: Text(isEnabled ? 'Enabled' : 'Disabled'),
        ),
      ),
    );
  }
}

Preview (Customized using icon props in `styleFrom` methods)

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

QuncCccccc · 2024-09-09T16:49:15Z

packages/flutter/test/material/elevated_button_test.dart

+  });
+
+  // This is a test regression for https://github.com/flutter/flutter/issues/154798.
+  test('ElevatedButton.styleFrom constructor', () {


Just a question, what is this unit test testing for?

This tests all the expected styleFrom method parameters. Some existing tests only verify some of the styleFrom properties but not every parameter hence we missed some icon properties.

This test is regular test not a widget test, just verifying props similar to debug fill properties tests.

What if you create an additional ButtonStyle with the same parameters but with the normal ButtonStyle constructor, and then compare their equality? Not sure if that would work like I'm thinking it would, but if so it would fail if an additional parameter is added to ButtonStyle but not to styleFrom, which would be pretty valuable.

@justinmc Something like this?

// Regression test for https://github.com/flutter/flutter/issues/154798. test('ElevatedButton.styleFrom constructor', () { const Color foregroundColor = Color(0xFF000022); const Color backgroundColor = Color(0xFF000011); const Color disabledForegroundColor = Color(0xFF000033); const Color disabledBackgroundColor = Color(0xFF000044); const Color shadowColor = Color(0xFF000066); const Color surfaceTintColor = Color(0xFF000077); const Color iconColor = Color(0xFF000088); const double iconSize = 32.0; const Color disabledIconColor = Color(0xFF000099); const Color overlayColor = Color(0xFF000055); const double elevation = 10.0; const TextStyle textStyle = TextStyle(fontSize: 21.0); const EdgeInsetsGeometry padding = EdgeInsets.all(16.0); const Size minimumSize = Size(88.0, 36.0); const Size fixedSize = Size(100.0, 50.0); const Size maximumSize = Size(120.0, 48.0); const BorderSide side = BorderSide(width: 2.0, color: Color(0xFF0000AA)); final OutlinedBorder shape = RoundedRectangleBorder(borderRadius: BorderRadius.circular(8.0)); const MouseCursor enabledMouseCursor = SystemMouseCursors.click; const MouseCursor disabledMouseCursor = SystemMouseCursors.basic; const VisualDensity visualDensity = VisualDensity.compact; const MaterialTapTargetSize tapTargetSize = MaterialTapTargetSize.shrinkWrap; const Duration animationDuration = Duration(milliseconds: 200); const bool enableFeedback = true; const AlignmentGeometry alignment = Alignment.center; const InteractiveInkFeatureFactory splashFactory = InkRipple.splashFactory; Widget backgroundBuilder(BuildContext context, Set<WidgetState> states, Widget? child) { return const SizedBox(); } Widget foregroundBuilder(BuildContext context, Set<WidgetState> states, Widget? child) { return const SizedBox(); } final ButtonStyle styleFrom = ElevatedButton.styleFrom( foregroundColor: foregroundColor, backgroundColor: backgroundColor, disabledForegroundColor: disabledForegroundColor, disabledBackgroundColor: disabledBackgroundColor, shadowColor: shadowColor, surfaceTintColor: surfaceTintColor, iconColor: iconColor, iconSize: iconSize, disabledIconColor: disabledIconColor, overlayColor: overlayColor, elevation: elevation, textStyle: textStyle, padding: padding, minimumSize: minimumSize, fixedSize: fixedSize, maximumSize: maximumSize, side: side, shape: shape, enabledMouseCursor: enabledMouseCursor, disabledMouseCursor: disabledMouseCursor, visualDensity: visualDensity, tapTargetSize: tapTargetSize, animationDuration: animationDuration, enableFeedback: enableFeedback, alignment: alignment, splashFactory: splashFactory, backgroundBuilder: backgroundBuilder, foregroundBuilder: foregroundBuilder, ); final ButtonStyle buttonStyle = ButtonStyle( foregroundColor: ButtonStyleButton.defaultColor(foregroundColor, disabledForegroundColor), backgroundColor: ButtonStyleButton.defaultColor(backgroundColor, disabledBackgroundColor), shadowColor: const WidgetStatePropertyAll<Color?>(shadowColor), surfaceTintColor: const WidgetStatePropertyAll<Color?>(surfaceTintColor), iconColor: ButtonStyleButton.defaultColor(iconColor, disabledIconColor), iconSize: const WidgetStatePropertyAll<double>(iconSize), overlayColor: const WidgetStatePropertyAll<Color?>(overlayColor), elevation: const WidgetStatePropertyAll<double>(elevation), textStyle: const WidgetStatePropertyAll<TextStyle?>(textStyle), padding: const WidgetStatePropertyAll<EdgeInsetsGeometry>(padding), minimumSize: const WidgetStatePropertyAll<Size>(minimumSize), fixedSize: const WidgetStatePropertyAll<Size>(fixedSize), maximumSize: const WidgetStatePropertyAll<Size>(maximumSize), side: const WidgetStatePropertyAll<BorderSide>(side), shape: WidgetStatePropertyAll<OutlinedBorder>(shape), mouseCursor: const WidgetStateProperty<MouseCursor?>.fromMap( <WidgetStatesConstraint, MouseCursor?>{ WidgetState.disabled: disabledMouseCursor, WidgetState.any: enabledMouseCursor, }, ), visualDensity: visualDensity, tapTargetSize: tapTargetSize, animationDuration: animationDuration, enableFeedback: enableFeedback, alignment: alignment, splashFactory: splashFactory, backgroundBuilder: backgroundBuilder, foregroundBuilder: foregroundBuilder, ); expect( styleFrom.foregroundColor!.resolve(<WidgetState>{ WidgetState.disabled }), buttonStyle.foregroundColor!.resolve(<WidgetState>{ WidgetState.disabled }), ); expect( styleFrom.foregroundColor!.resolve(<WidgetState>{}), buttonStyle.foregroundColor!.resolve(<WidgetState>{}), ); expect( styleFrom.backgroundColor!.resolve(<WidgetState>{ WidgetState.disabled }), buttonStyle.backgroundColor!.resolve(<WidgetState>{ WidgetState.disabled }), ); expect( styleFrom.backgroundColor!.resolve(<WidgetState>{}), buttonStyle.backgroundColor!.resolve(<WidgetState>{}), ); expect( styleFrom.shadowColor!.resolve(<WidgetState>{}), buttonStyle.shadowColor!.resolve(<WidgetState>{}), ); expect( styleFrom.surfaceTintColor!.resolve(<WidgetState>{}), buttonStyle.surfaceTintColor!.resolve(<WidgetState>{}), ); expect( styleFrom.iconColor!.resolve(<WidgetState>{ WidgetState.disabled }), buttonStyle.iconColor!.resolve(<WidgetState>{ WidgetState.disabled }), ); expect( styleFrom.iconColor!.resolve(<WidgetState>{}), buttonStyle.iconColor!.resolve(<WidgetState>{}), ); expect( styleFrom.iconSize!.resolve(<WidgetState>{}), buttonStyle.iconSize!.resolve(<WidgetState>{}), ); expect(styleFrom.overlayColor!.resolve(<WidgetState>{}), null); // This is null when a foreground is provided. expect( styleFrom.elevation!.resolve(<WidgetState>{}), buttonStyle.elevation!.resolve(<WidgetState>{}), ); expect( styleFrom.textStyle!.resolve(<WidgetState>{}), buttonStyle.textStyle!.resolve(<WidgetState>{}), ); expect( styleFrom.padding!.resolve(<WidgetState>{}), buttonStyle.padding!.resolve(<WidgetState>{}), ); expect( styleFrom.minimumSize!.resolve(<WidgetState>{}), buttonStyle.minimumSize!.resolve(<WidgetState>{}), ); expect( styleFrom.fixedSize!.resolve(<WidgetState>{}), buttonStyle.fixedSize!.resolve(<WidgetState>{}), ); expect( styleFrom.maximumSize!.resolve(<WidgetState>{}), buttonStyle.maximumSize!.resolve(<WidgetState>{}), ); expect( styleFrom.side!.resolve(<WidgetState>{}), buttonStyle.side!.resolve(<WidgetState>{}), ); expect( styleFrom.shape!.resolve(<WidgetState>{}), buttonStyle.shape!.resolve(<WidgetState>{}), ); expect( styleFrom.mouseCursor!.resolve(<WidgetState>{ WidgetState.disabled }), buttonStyle.mouseCursor!.resolve(<WidgetState>{ WidgetState.disabled }), ); expect( styleFrom.mouseCursor!.resolve(<WidgetState>{}), buttonStyle.mouseCursor!.resolve(<WidgetState>{}), ); expect(styleFrom.visualDensity, buttonStyle.visualDensity); expect(styleFrom.tapTargetSize, buttonStyle.tapTargetSize); expect(styleFrom.animationDuration, buttonStyle.animationDuration); expect(styleFrom.enableFeedback, buttonStyle.enableFeedback); expect(styleFrom.alignment, buttonStyle.alignment); expect(styleFrom.splashFactory, buttonStyle.splashFactory); expect(styleFrom.backgroundBuilder, buttonStyle.backgroundBuilder); expect(styleFrom.foregroundBuilder, buttonStyle.foregroundBuilder); });

My guess is that it would just need 1 equality check:

expect(styleFrom == buttonStyle, isTrue);

Though if we were to add a ButtonStyle property without updating this test, they would both be initialized to null and we likely wouldn't be able to catch that .styleFrom() was missing something.

expect(styleFrom == buttonStyle, isTrue); is same as expect(styleFrom, buttonStyle);.

I tried this already. Either checks won't work as the some of the individuals properties return different types. We will have to break down each properties like i did in the #154821 (comment).

Oh I like this idea but seems this new change still can not catch newly added property in ButtonStyle? If so, probably we can just keep the original tests.

Further more, I'm just thinking whether these constructor tests are necessary because they don't have any expect()s and seems can only make sure .styleFrom method doesn't throw exception? xxButton.styleFrom is just to provide a more convenient way to customize buttons, so probably it is okay to have some mismatch properties with ButtonStyle, for example .stylefrom has foregroundColor and disabledForegroundColor but ButtonStyle only has foregroundColor with a WidgetStateProperty type.

Further more, I'm just thinking whether these constructor tests are necessary because they don't have any expect()s and seems can only make sure .styleFrom method doesn't throw exception?

The test doesn't expect to not throw exception, the test only use constructor in the same older as the implementation to not miss any props.

Sure, I can remove these constructor tests. We should make sure to sync all classes using styleFrom when new properties are introduced in styleFrom. As this PR adds missing styleFrom props in seven methods.

nate-thegrate

This looks really great overall. I wanted to share a few tiny suggestions (and unfortunately they involve a lot of copy/pasting, so apologies for that).

packages/flutter/lib/src/material/elevated_button.dart

packages/flutter/test/material/elevated_button_test.dart

packages/flutter/test/material/segmented_button_test.dart

nate-thegrate · 2024-09-10T00:23:12Z

Also, apologies for the merge conflicts, that's on me 😅

(though to be fair, #154695 was opened before #154798 was)

TahaTesser · 2024-09-10T11:50:34Z

Also, apologies for the merge conflicts, that's on me 😅

(though to be fair, #154695 was opened before #154798 was)

FYI, I see no conflict in text_button.dart, only in other buttons. The iconColor line isn't updated in this class.

flutter/packages/flutter/lib/src/material/text_button.dart

Line 252 in d6e2b6a

iconColor: iconColorProp,

flutter/packages/flutter/lib/src/material/elevated_button.dart

Line 263 in d6e2b6a

iconColor: ButtonStyleButton.defaultColor(iconColor, disabledIconColor),

nate-thegrate

LGTM!

There's a rich variety of improvements in this PR; looking forward to seeing it get merged in 🙂

nate-thegrate · 2024-09-10T15:17:34Z

packages/flutter/test/material/elevated_button_test.dart

+  });
+
+  // This is a test regression for https://github.com/flutter/flutter/issues/154798.
+  test('ElevatedButton.styleFrom constructor', () {


My guess is that it would just need 1 equality check:

expect(styleFrom == buttonStyle, isTrue);

Though if we were to add a ButtonStyle property without updating this test, they would both be initialized to null and we likely wouldn't be able to catch that .styleFrom() was missing something.

QuncCccccc

LGTM:) Thanks!

…/flutter#154821)

Manual roll requested by [email protected] flutter/flutter@c4c9f47...7fe8237 2024-09-18 [email protected] Roll Flutter Engine from 4bdcbf39c200 to 15e9e3153266 (1 revision) (flutter/flutter#155371) 2024-09-18 [email protected] Roll Flutter Engine from fdf38910bad4 to 4bdcbf39c200 (5 revisions) (flutter/flutter#155368) 2024-09-18 [email protected] Roll Packages from 4f2b9cd to c7406b3 (1 revision) (flutter/flutter#155362) 2024-09-18 [email protected] Roll Flutter Engine from 4f2d866aef32 to fdf38910bad4 (1 revision) (flutter/flutter#155339) 2024-09-18 [email protected] Roll Flutter Engine from 311ba971bb3a to 4f2d866aef32 (4 revisions) (flutter/flutter#155329) 2024-09-18 [email protected] Fix missing icon props in button `styleFrom` methods (flutter/flutter#154821) 2024-09-17 [email protected] Roll Flutter Engine from 0ef18a3ef064 to 311ba971bb3a (8 revisions) (flutter/flutter#155325) 2024-09-17 [email protected] [CupertinoAlertDialog] Add tap-slide gesture (flutter/flutter#154853) 2024-09-17 [email protected] Uninstall /can fail/ (flutter/flutter#155314) 2024-09-17 [email protected] Roll Packages from df88c81 to 4f2b9cd (3 revisions) (flutter/flutter#155312) 2024-09-17 [email protected] Roll Flutter Engine from a1700b9ea2db to 0ef18a3ef064 (1 revision) (flutter/flutter#155311) 2024-09-17 [email protected] Roll Flutter Engine from 1376288f5c2a to a1700b9ea2db (2 revisions) (flutter/flutter#155290) 2024-09-17 [email protected] Delete packages/flutter_tools/lib/src/fuchsia directory (flutter/flutter#154880) 2024-09-17 [email protected] Adds ColorSwatch matcher (flutter/flutter#155272) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…/flutter#154821)

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 9, 2024

TahaTesser marked this pull request as ready for review September 9, 2024 14:22

TahaTesser requested a review from QuncCccccc September 9, 2024 14:22

QuncCccccc reviewed Sep 9, 2024

View reviewed changes

nate-thegrate reviewed Sep 9, 2024

View reviewed changes

TahaTesser force-pushed the fix_icon_props_style_from_methods branch 2 times, most recently from d67597c to 4d077df Compare September 10, 2024 10:01

TahaTesser requested a review from QuncCccccc September 10, 2024 11:50

nate-thegrate approved these changes Sep 10, 2024

View reviewed changes

TahaTesser requested a review from justinmc September 11, 2024 15:35

TahaTesser force-pushed the fix_icon_props_style_from_methods branch from 4d077df to c867f46 Compare September 13, 2024 08:37

QuncCccccc approved these changes Sep 16, 2024

View reviewed changes

Fix missing icon props in button styleFrom methods

d0fdad3

TahaTesser force-pushed the fix_icon_props_style_from_methods branch from c867f46 to d0fdad3 Compare September 17, 2024 20:50

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2024

auto-submit bot merged commit d5e843e into flutter:master Sep 18, 2024

TahaTesser deleted the fix_icon_props_style_from_methods branch September 18, 2024 00:51

engine-flutter-autoroll mentioned this pull request Sep 18, 2024

Roll Flutter from c4c9f47c479d to 1cd629fe1921 (11 revisions) flutter/packages#7658

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 18, 2024

d5e843e Fix missing icon props in button styleFrom methods (flutter…

d09f137

…/flutter#154821)

engine-flutter-autoroll mentioned this pull request Sep 18, 2024

Roll Flutter from c4c9f47c479d to 20ba964c90a7 (12 revisions) flutter/packages#7659

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 18, 2024

d5e843e Fix missing icon props in button styleFrom methods (flutter…

76280b8

…/flutter#154821)

engine-flutter-autoroll mentioned this pull request Sep 18, 2024

Roll Flutter from c4c9f47c479d to d4a9fa70a868 (13 revisions) flutter/packages#7661

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 18, 2024

d5e843e Fix missing icon props in button styleFrom methods (flutter…

191b0b5

…/flutter#154821)

engine-flutter-autoroll mentioned this pull request Sep 18, 2024

Roll Flutter from c4c9f47c479d to 7fe82377f950 (14 revisions) flutter/packages#7662

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 18, 2024

d5e843e Fix missing icon props in button styleFrom methods (flutter…

806a243

…/flutter#154821)

engine-flutter-autoroll mentioned this pull request Sep 18, 2024

Manual roll Flutter from c4c9f47c479d to 7fe82377f950 (14 revisions) flutter/packages#7663

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 18, 2024

d5e843e Fix missing icon props in button styleFrom methods (flutter…

077f331

…/flutter#154821)

Piinks mentioned this pull request Sep 27, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

d5e843e Fix missing icon props in button styleFrom methods (flutter…

8921317

…/flutter#154821)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

d5e843e Fix missing icon props in button styleFrom methods (flutter…

e091768

…/flutter#154821)

This was referenced Dec 12, 2024

Update icon color & icon size assignment to align with new Flutter 3.27.0 breaking changes letsar/flutter_slidable#513

Closed

Icon in SlidableAction is not using foreground color letsar/flutter_slidable#512

Closed

Fix missing icon props in button styleFrom methods #154821

Fix missing icon props in button styleFrom methods #154821

Uh oh!

Conversation

TahaTesser commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Code sample

Preview (Customized using icon props in styleFrom methods)

Pre-launch Checklist

Uh oh!

QuncCccccc Sep 9, 2024

Choose a reason for hiding this comment

Uh oh!

TahaTesser Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc Sep 9, 2024

Choose a reason for hiding this comment

Uh oh!

TahaTesser Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nate-thegrate Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

TahaTesser Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Sep 12, 2024

Choose a reason for hiding this comment

Uh oh!

TahaTesser Sep 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nate-thegrate left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nate-thegrate commented Sep 10, 2024

Uh oh!

TahaTesser commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nate-thegrate left a comment

Choose a reason for hiding this comment

Uh oh!

nate-thegrate Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix missing icon props in button `styleFrom` methods #154821

Fix missing icon props in button `styleFrom` methods #154821

TahaTesser commented Sep 9, 2024 •

edited

Loading

Preview (Customized using icon props in `styleFrom` methods)

TahaTesser Sep 9, 2024 •

edited

Loading

TahaTesser Sep 10, 2024 •

edited

Loading

TahaTesser Sep 13, 2024 •

edited

Loading

TahaTesser commented Sep 10, 2024 •

edited

Loading