-
Notifications
You must be signed in to change notification settings - Fork 29.7k
CheckboxListTile: add property to scale the checkbox #154806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Copying comment from the Discord on the test: "There's a test file for the CheckBoxListTile in packages/flutter/test/material. I imagine you can just find the checkbox widget and get it's corners then compare them against an expected value, but if that doesn't work, you can look up the tests for Transform.scale and see if there's a helpful one there to get you started." |
|
Hi @MitchellGoodwin Thanks |
MitchellGoodwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit! Thank you very much for putting this together. Once then nit is addressed I'll see about getting a secondary reviewer, than this can be merged.
|
@itsjatinnagar the linked issue also mentions scaling the underlying |
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but +1 to @victorsanni's comment about the docs.
Yes, I am going to raise a new PR for |
Added a property in the CheckboxListTile to scale the underlying Checkbox using
Transform.scale.Fixes: #81334
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.