[CP-stable]Fix Drawer prematurely snapping
#154720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regression is due to the fact that `animationController.isAnimating` and `animationController.status.isAnimating` sometimes return opposite values. This PR implements & tests the bugfix, and also adds documentation to explain this behavior. <br> fixes flutter#153851 cc @azeunkn0wn @huycozy
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
framework
Contributor
itsjustkevin
added
the
autosubmit
nate-thegrate
added
cp: merged
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 13, 2024
ghost
mentioned this pull request
9 tasks
AhmedMagdy-10
pushed a commit
to AhmedMagdy-10/flutter
that referenced
this pull request
Oct 6, 2024
nxjdrk
pushed a commit
to nxjdrk/flutter
that referenced
this pull request
Oct 9, 2024
Gustl22
pushed a commit
to Gustl22/flutter
that referenced
this pull request
Nov 13, 2024
…er#155044) # Flutter stable 3.24.3 Framework ## Scheduled Cherrypicks - flutter#154380 - flutter#154720 - flutter#154944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link
#154722
Target
stable
Cherry pick PR Link
#154720
Changelog Description
The
Drawerwidget will snap completely open or shut after being dragged more than halfway.Impacted Users
This affects everyone who has a
Drawerwidget in their mobile app.Impact Description
Fortunately, the impact of this issue is limited to visual jank. But it will likely be widespread across app developers.
Workaround
There isn't a workaround for this.
Risk
low (This fix was merged over 2 weeks ago.)
Test Coverage
This fix is covered by the test added in the linked pull request.
Validation Steps
The fix can be verified by opening a mobile Flutter app and dragging a
Draweropen or shut.