Skip to content

Remove allowoptimization modifier from FlutterPlugin proguard rules #154715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Sep 6, 2024
Merged

Remove allowoptimization modifier from FlutterPlugin proguard rules #154715

auto-submit merged 1 commit into from
Sep 6, 2024

Conversation

@rajveermalviya
Copy link
Contributor

@rajveermalviya rajveermalviya commented Sep 6, 2024 •
edited
Loading

Fixes: #154580
Previous PR: #154677
More info: #154580 (comment)

The errors described in the original issue are still occurring after #154677. Before this change, the repro broken_demo mentioned in the original issue logs:

$ flutter run --release
Launching lib/main.dart on sdk gphone64 arm64 in release mode...
Running Gradle task 'assembleRelease'...                           14.5s
✓ Built build/app/outputs/flutter-apk/app-release.apk (7.4MB)
Installing build/app/outputs/flutter-apk/app-release.apk...        739ms

Flutter run key commands.
h List all available interactive commands.
c Clear the screen
q Quit (terminate the application on the device).
W/FlutterEngineCxnRegstry(13284): Attempted to register plugin (a0.a@53b33b6) but it was already registered with this FlutterEngine (d0.c@8baa8b7).
E/flutter (13284): [ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception: PlatformException(channel-error, Unable to establish connection on channel., null, null)
E/flutter (13284): #0      PathProviderApi.getApplicationSupportPath (package:path_provider_android/messages.g.dart:65)
E/flutter (13284): <asynchronous suspension>
E/flutter (13284): #1      getApplicationSupportDirectory (package:path_provider/path_provider.dart:78)
E/flutter (13284): <asynchronous suspension>
E/flutter (13284): #2      _BorkenDemoHomePageState.build.<anonymous closure> (package:broken_demo/main.dart:44)
E/flutter (13284): <asynchronous suspension>
E/flutter (13284):

After this change:

$ flutter run --release
Launching lib/main.dart on sdk gphone64 arm64 in release mode...
Running Gradle task 'assembleRelease'...                           15.2s
✓ Built build/app/outputs/flutter-apk/app-release.apk (7.4MB)
Installing build/app/outputs/flutter-apk/app-release.apk...        857ms

Flutter run key commands.
h List all available interactive commands.
c Clear the screen
q Quit (terminate the application on the device).
I/flutter (13040): path_provider: Directory: '/data/user/0/com.example.broken_demo/files'

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 6, 2024

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 6, 2024
@rajveermalviya
Copy link
Contributor Author

rajveermalviya commented Sep 6, 2024

cc @gmackall

@rajveermalviya rajveermalviya mentioned this pull request Sep 6, 2024
Closed
@gmackall
Copy link
Member

gmackall commented Sep 6, 2024

Just double checked and this is also required for me, wonder why I didn't find that I needed this the first time...

Either way, it makes sense to me that would be required, so LGTM

@gmackall gmackall requested a review from a team September 6, 2024 16:56
@gmackall
Copy link
Member

gmackall commented Sep 6, 2024

FYI this just needs one more review, and I also requested it for test exemption on discord.

I'll take care of submitting it once both those pieces are handled

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 6, 2024
@auto-submit auto-submit bot merged commit 6ad6641 into flutter:master Sep 6, 2024
@rajveermalviya rajveermalviya deleted the pr-proguard-workaround branch September 6, 2024 20:48
@rajveermalviya rajveermalviya mentioned this pull request Sep 6, 2024
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
bec4ee7 
… rules (flutter/flutter#154715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
adc9656 
… rules (flutter/flutter#154715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
724f41d 
… rules (flutter/flutter#154715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
c3f8944 
… rules (flutter/flutter#154715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
b83d0e0 
… rules (flutter/flutter#154715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
f3494df 
… rules (flutter/flutter#154715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
56ad983 
… rules (flutter/flutter#154715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
7376563 
… rules (flutter/flutter#154715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
0c185d8 
… rules (flutter/flutter#154715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
12ece2d 
… rules (flutter/flutter#154715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
9184cf1 
… rules (flutter/flutter#154715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
c1096d2 
… rules (flutter/flutter#154715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
394cc69 
… rules (flutter/flutter#154715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
79a4b07 
… rules (flutter/flutter#154715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
0a29cb2 
… rules (flutter/flutter#154715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
2a81a45 
… rules (flutter/flutter#154715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
37ac120 
… rules (flutter/flutter#154715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
81e4d89 
… rules (flutter/flutter#154715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
308b0b1 
… rules (flutter/flutter#154715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
ebc5ace 
… rules (flutter/flutter#154715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
d0653da 
… rules (flutter/flutter#154715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
d9f343d 
… rules (flutter/flutter#154715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
f425fb2 
… rules (flutter/flutter#154715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
b05aba7 
… rules (flutter/flutter#154715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
c9e0066 
… rules (flutter/flutter#154715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
f616526 
… rules (flutter/flutter#154715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
6ad6641 Remove allowoptimization modifier from FlutterPlugin proguard…
9b72955 
… rules (flutter/flutter#154715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@gmackall gmackall gmackall approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

path_provider package breaks in release mode, if app also depends on device_info_plus, after b2de4df

3 participants

@rajveermalviya @gmackall @reidbaker