Skip to content

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Sep 3, 2024

In flutter/engine#54414, we added dSYM files for physical and simulator binaries in both regular and extension-safe framework builds. In flutter/engine#54576 we added the dSYMs to the without_entitlements.txt list.

The dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart test was updated to reflect these changes in:

This cherrypicks these two changes to the release branch.

Issue: #116493

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

In flutter/engine#54414, we added dSYM files for physical and simulator binaries in both regular and extension-safe framework builds. In flutter/engine#54576 we added the dSYMs to the without_entitlements.txt list.

The `dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart` test was updated to reflect these changes in:
* flutter#153787
* flutter#154027

This cherrypicks these two changes to the release branch.

Issue: flutter#116493
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 3, 2024

auto label is removed for flutter/flutter/154582, due to - The status or check suite Windows module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2024
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2024
@auto-submit auto-submit bot merged commit 4cf269e into flutter:flutter-3.24-candidate.0 Sep 3, 2024
@cbracken cbracken deleted the add-dsyms-for-3.24-candidate.0 branch September 3, 2024 21:41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
Gustl22 pushed a commit to Gustl22/flutter that referenced this pull request Nov 13, 2024
In flutter/engine#54414, we added dSYM files for physical and simulator binaries in both regular and extension-safe framework builds. In flutter/engine#54576 we added the dSYMs to the without_entitlements.txt list.

The `dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart` test was updated to reflect these changes in:
* flutter#153787
* flutter#154027

This cherrypicks these two changes to the release branch.

Issue: flutter#116493
@LassZhang
Copy link

I need help . my error log is : The archive did not include a dSYM for the WebRTC.framework with the UUIDs [4C4C4468-5555-3144-A192-E653D6FF67CB]. Ensure that the archive's dSYM folder includes a DWARF file for WebRTC.framework with the expected UUIDs. and i can't find the WebRTC.framework .dSYM in the dSYMs folder , as the follow image1 .My XCode config is like the follow picture image2
image1
image2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants