[flutter_releases] Flutter stable 3.24.0 Framework Cherrypicks #154430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r stable release 3.24.0
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
Contributor
|
Before merging this, please update CHANGELOG.md with the release notes. |
Contributor
Author
Done, the tag url does not exist yet but I think that is expected so I guessed it would be 3.24.2 |
CHANGELOG.md
Outdated
| - [flutter/153949](https://github.com/flutter/flutter/issues/153949): Fix a crash when deleting text inside CupertinoPageRoute, with a CJK (chinese, japanese, korean) keyboard on Android. | ||
| - [flutter/153939](https://github.com/flutter/flutter/issues/153939): Fixes an issue where Flutter TextField may stop accepting input on iOS. | ||
| - [flutter/152420](https://github.com/flutter/flutter/issues/152420): Fixes scrolling jank when a SelectionArea/SelectableRegion is used as a child of a Scrollable like ListView or PageView on Android and iOS. | ||
| - [flutter/154199](https://github.com/flutter/flutter/pull/154199): Removes log spam when building a freshly created template app for Android. |
Contributor
There was a problem hiding this comment.
Suggested change
| - [flutter/154199](https://github.com/flutter/flutter/pull/154199): Removes log spam when building a freshly created template app for Android. | |
| - [flutter/154199](https://github.com/flutter/flutter/pull/154199): Simplifies logs when building a freshly created template app for Android. |
Contributor
There was a problem hiding this comment.
I don't understand where this comes in. Is this when we pass a specific flag. Why specifically Android?
Contributor
Author
There was a problem hiding this comment.
This is incorrect the pr does not simplify the log message. It removes the log message by fixing a non fatal condition.
Contributor
There was a problem hiding this comment.
Thanks for clarifying, but log spam may not make sense to non-native English speakers.
Contributor
Author
There was a problem hiding this comment.
Going with "Excessive logging" (thanks go/duckie)
| - [flutter/152420](https://github.com/flutter/flutter/issues/152420): Fixes scrolling jank when a SelectionArea/SelectableRegion is used as a child of a Scrollable like ListView or PageView on Android and iOS. | ||
| - [flutter/154199](https://github.com/flutter/flutter/pull/154199): Removes log spam when building a freshly created template app for Android. | ||
| - [flutter/153967](https://github.com/flutter/flutter/pull/153967): Fixes macOS host build failure when there are no native asset frameworks to codesign. Impacts users who have enabled experimental native assets feature. | ||
| - [flutter/153769](https://github.com/flutter/flutter/pull/153769): When running a Flutter app, display a concise error message when connection to the device is lost. |
Contributor
There was a problem hiding this comment.
Suggested change
| - [flutter/153769](https://github.com/flutter/flutter/pull/153769): When running a Flutter app, display a concise error message when connection to the device is lost. | |
| - [flutter/153769](https://github.com/flutter/flutter/pull/153769): Simplifies the error message when the connection is lost with a connected device when running a Flutter app. |
Contributor
Author
There was a problem hiding this comment.
How is this better or easier to read?
| - [flutter/154199](https://github.com/flutter/flutter/pull/154199): Removes log spam when building a freshly created template app for Android. | ||
| - [flutter/153967](https://github.com/flutter/flutter/pull/153967): Fixes macOS host build failure when there are no native asset frameworks to codesign. Impacts users who have enabled experimental native assets feature. | ||
| - [flutter/153769](https://github.com/flutter/flutter/pull/153769): When running a Flutter app, display a concise error message when connection to the device is lost. | ||
| - [flutter/154270](https://github.com/flutter/flutter/pull/154270): Prevent preemptive gradle crash for android builds that would fail to build anyway but with a confusing error message. |
Contributor
There was a problem hiding this comment.
As a user, this message seems confusing.
Contributor
Author
There was a problem hiding this comment.
I am open to suggestions but this is the best I could do while trying to be accurate and simple and one line.
reidbaker
commented
Sep 3, 2024
CHANGELOG.md
Outdated
| - [flutter/153949](https://github.com/flutter/flutter/issues/153949): Fix a crash when deleting text inside CupertinoPageRoute, with a CJK (chinese, japanese, korean) keyboard on Android. | ||
| - [flutter/153939](https://github.com/flutter/flutter/issues/153939): Fixes an issue where Flutter TextField may stop accepting input on iOS. | ||
| - [flutter/152420](https://github.com/flutter/flutter/issues/152420): Fixes scrolling jank when a SelectionArea/SelectableRegion is used as a child of a Scrollable like ListView or PageView on Android and iOS. | ||
| - [flutter/154199](https://github.com/flutter/flutter/pull/154199): Removes log spam when building a freshly created template app for Android. |
Contributor
Author
There was a problem hiding this comment.
Going with "Excessive logging" (thanks go/duckie)
reidbaker
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
Gustl22
pushed a commit
to Gustl22/flutter
that referenced
this pull request
Nov 13, 2024
…er#154430) # Flutter stable 3.24.0 Framework ## Scheduled Cherrypicks [flutter/153949](flutter#153949): Fix a crash when deleting text inside CupertinoPageRoute, with a CJK (chinese, japanese, korean) keyboard on Android. [flutter/153939](flutter#153939): Fixes an issue where Flutter TextField may stop accepting input on iOS. [flutter/152420](flutter#152420): Fixes scrolling jank when a SelectionArea/SelectableRegion is used as a child of a Scrollable like ListView or PageView on Android and iOS. [flutter/154199](flutter#154199): Removes log spam when building a freshly created template app for Android. [flutter/153967](flutter#153967): Fixes macOS host build failure when there are no native asset frameworks to codesign. Impacts users who have enabled experimental native assets feature. [flutter/153769](flutter#153769): When running a Flutter app, display a concise error message when connection to the device is lost. [flutter/154270](flutter#154270): Prevent preemptive gradle crash for android builds that would fail to build anyway but with a confusing error message. [flutter/54735](flutter/engine#54735): When semantics are enabled on Web, the onTap of various widgets (GestureDetector, InkWell) are called twice or the callback from one widget is called when another widget is pressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flutter stable 3.24.0 Framework
Scheduled Cherrypicks
flutter/153949: Fix a crash when deleting text inside CupertinoPageRoute, with a CJK (chinese, japanese, korean) keyboard on Android.
flutter/153939: Fixes an issue where Flutter TextField may stop accepting input on iOS.
flutter/152420: Fixes scrolling jank when a SelectionArea/SelectableRegion is used as a child of a Scrollable like ListView or PageView on Android and iOS.
flutter/154199: Removes log spam when building a freshly created template app for Android.
flutter/153967: Fixes macOS host build failure when there are no native asset frameworks to codesign. Impacts users who have enabled experimental native assets feature.
flutter/153769: When running a Flutter app, display a concise error message when connection to the device is lost.
flutter/154270: Prevent preemptive gradle crash for android builds that would fail to build anyway but with a confusing error message.
flutter/54735: When semantics are enabled on Web, the onTap of various widgets (GestureDetector, InkWell) are called twice or the callback from one widget is called when another widget is pressed.