Skip to content

Conversation

@flutteractionsbot
Copy link

@flutteractionsbot flutteractionsbot commented Aug 28, 2024

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#153668. Original PR at #154121.

Changelog Description:

Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples

Fixes a tool crash case when building for Android.

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Causes a crash when building for Android in some cases.

Workaround:

Is there a workaround for this issue?

Build with the --android-skip-build-dependency-validation flag.

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

< Replace with validation steps here >

…checking it (flutter#154121)

Make sure `usesUnsupportedDependencyVersions` property exists before checking it in the Flutter Gradle plugin.

Related to: flutter#153668 (doesn't fix, will need to cherry pick to fix).
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Aug 28, 2024
@flutteractionsbot
Copy link
Author

@gmackall please fill out the PR description above, afterwards the release team will review this request.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 28, 2024
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2024
@auto-submit auto-submit bot merged commit 348da8b into flutter:flutter-3.24-candidate.0 Aug 28, 2024
auto-submit bot pushed a commit that referenced this pull request Sep 3, 2024
# Flutter stable 3.24.0 Framework

## Scheduled Cherrypicks
[flutter/153949](#153949): Fix a crash when deleting text inside CupertinoPageRoute, with a CJK (chinese, japanese, korean) keyboard on Android. 
[flutter/153939](#153939): Fixes an issue where Flutter TextField may stop accepting input on iOS.
[flutter/152420](#152420): Fixes scrolling jank when a SelectionArea/SelectableRegion is used as a child of a Scrollable like ListView or PageView on Android and iOS. 
[flutter/154199](#154199): Removes log spam when building a freshly created template app for Android.
[flutter/153967](#153967): Fixes macOS host build failure when there are no native asset frameworks to codesign. Impacts users who have enabled experimental native assets feature. 
[flutter/153769](#153769): When running a Flutter app, display a concise error message when connection to the device is lost.
[flutter/154270](#154270): Prevent preemptive gradle crash for android builds that would fail to build anyway but with a confusing error message. 
[flutter/54735](flutter/engine#54735): When semantics are enabled on Web, the onTap of various widgets (GestureDetector, InkWell) are called twice or the callback from one widget is called when another widget is pressed.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
Gustl22 pushed a commit to Gustl22/flutter that referenced this pull request Nov 13, 2024
…er#154430)

# Flutter stable 3.24.0 Framework

## Scheduled Cherrypicks
[flutter/153949](flutter#153949): Fix a crash when deleting text inside CupertinoPageRoute, with a CJK (chinese, japanese, korean) keyboard on Android.
[flutter/153939](flutter#153939): Fixes an issue where Flutter TextField may stop accepting input on iOS.
[flutter/152420](flutter#152420): Fixes scrolling jank when a SelectionArea/SelectableRegion is used as a child of a Scrollable like ListView or PageView on Android and iOS.
[flutter/154199](flutter#154199): Removes log spam when building a freshly created template app for Android.
[flutter/153967](flutter#153967): Fixes macOS host build failure when there are no native asset frameworks to codesign. Impacts users who have enabled experimental native assets feature.
[flutter/153769](flutter#153769): When running a Flutter app, display a concise error message when connection to the device is lost.
[flutter/154270](flutter#154270): Prevent preemptive gradle crash for android builds that would fail to build anyway but with a confusing error message.
[flutter/54735](flutter/engine#54735): When semantics are enabled on Web, the onTap of various widgets (GestureDetector, InkWell) are called twice or the callback from one widget is called when another widget is pressed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App cp: review Cherry-picks in the review queue tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants