[CP-stable]Reland "Upgrade template Gradle, App AGP, Module AGP, and Kotlin versions, and tests"... but no longer upgrade module AGP version #154199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions, and tests"... but no longer upgrade module AGP version (flutter#151433) Relands flutter#150969, but removes the upgrade to the module AGP version. The reason is that a more complicated change is required because in AGP 8.0 software components are no longer generated by default, but rather only generated for variants that are configured to be published using the publishing DSL (see the `android.disableAutomaticComponentCreation` section of https://developer.android.com/build/releases/past-releases/agp-8-0-0-release-notes). That broke our aar initialization script, because the components didn't exist so the `aar` tasks never got [created here](https://github.com/flutter/flutter/blob/9ff9c67272f7f95c7d53ac3f89e0b659df9ddf3e/packages/flutter_tools/gradle/aar_init_script.gradle#L29). Verified that the one postsubmit that failed now passes (`android_obfuscate_test`)
Author
|
@gmackall please fill out the PR description above, afterwards the release team will review this request. |
github-actions
bot
added
the
tool
Contributor
|
@gmackall to update pr description. |
Member
|
Updated. I'll still need to figure out why this one test is failing though - it didn't fail on the original PR. |
Member
|
I updated the AGP version in the test that was failing. This test was refactored on master, which is why this change wasn't required on the master version of the pr |
Contributor
|
Nvm camille is out @gmackall please review then add autosubmit. |
…ab51a3952584e1208718ab0396
gmackall
added
the
autosubmit
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
# Flutter stable 3.24.0 Framework ## Scheduled Cherrypicks [flutter/153949](#153949): Fix a crash when deleting text inside CupertinoPageRoute, with a CJK (chinese, japanese, korean) keyboard on Android. [flutter/153939](#153939): Fixes an issue where Flutter TextField may stop accepting input on iOS. [flutter/152420](#152420): Fixes scrolling jank when a SelectionArea/SelectableRegion is used as a child of a Scrollable like ListView or PageView on Android and iOS. [flutter/154199](#154199): Removes log spam when building a freshly created template app for Android. [flutter/153967](#153967): Fixes macOS host build failure when there are no native asset frameworks to codesign. Impacts users who have enabled experimental native assets feature. [flutter/153769](#153769): When running a Flutter app, display a concise error message when connection to the device is lost. [flutter/154270](#154270): Prevent preemptive gradle crash for android builds that would fail to build anyway but with a confusing error message. [flutter/54735](flutter/engine#54735): When semantics are enabled on Web, the onTap of various widgets (GestureDetector, InkWell) are called twice or the callback from one widget is called when another widget is pressed.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…GP, and Kotlin versions, and tests"... but no longer upgrade module AGP version (flutter/flutter#154199)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…GP, and Kotlin versions, and tests"... but no longer upgrade module AGP version (flutter/flutter#154199)
Gustl22
pushed a commit
to Gustl22/flutter
that referenced
this pull request
Nov 13, 2024
…er#154430) # Flutter stable 3.24.0 Framework ## Scheduled Cherrypicks [flutter/153949](flutter#153949): Fix a crash when deleting text inside CupertinoPageRoute, with a CJK (chinese, japanese, korean) keyboard on Android. [flutter/153939](flutter#153939): Fixes an issue where Flutter TextField may stop accepting input on iOS. [flutter/152420](flutter#152420): Fixes scrolling jank when a SelectionArea/SelectableRegion is used as a child of a Scrollable like ListView or PageView on Android and iOS. [flutter/154199](flutter#154199): Removes log spam when building a freshly created template app for Android. [flutter/153967](flutter#153967): Fixes macOS host build failure when there are no native asset frameworks to codesign. Impacts users who have enabled experimental native assets feature. [flutter/153769](flutter#153769): When running a Flutter app, display a concise error message when connection to the device is lost. [flutter/154270](flutter#154270): Prevent preemptive gradle crash for android builds that would fail to build anyway but with a confusing error message. [flutter/54735](flutter/engine#54735): When semantics are enabled on Web, the onTap of various widgets (GestureDetector, InkWell) are called twice or the callback from one widget is called when another widget is pressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#153885 (comment)
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Upgrades template Gradle, App AGP, and Kotlin versions.
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Fixes some log spam when building a freshly created template app for Android.
Workaround:
Is there a workaround for this issue?
Yes, just upgrade the output of the template manually.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
flutter create foo,cd foo,flutter build apk