-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Make sure usesUnsupportedDependencyVersions property exists before checking it
#154121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure usesUnsupportedDependencyVersions property exists before checking it
#154121
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
…checking it (flutter#154121) Make sure `usesUnsupportedDependencyVersions` property exists before checking it in the Flutter Gradle plugin. Related to: flutter#153668 (doesn't fix, will need to cherry pick to fix).
… before checking it (flutter/flutter#154121)
…sts before checking it (#154270) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #153668. Original PR at #154121. ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Fixes a tool crash case when building for Android. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Causes a crash when building for Android in some cases. ### Workaround: Is there a workaround for this issue? Build with the `--android-skip-build-dependency-validation` flag. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? < Replace with validation steps here >
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
…checking it (flutter#154121) Make sure `usesUnsupportedDependencyVersions` property exists before checking it in the Flutter Gradle plugin. Related to: flutter#153668 (doesn't fix, will need to cherry pick to fix).
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
… before checking it (flutter/flutter#154121)
Make sure
usesUnsupportedDependencyVersionsproperty exists before checking it in the Flutter Gradle plugin.Related to: #153668 (doesn't fix, will need to cherry pick to fix).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.