Skip to content

iOS: Update codesigned binaries list to match cache #154027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 23, 2024
Merged

iOS: Update codesigned binaries list to match cache #154027

auto-submit merged 1 commit into from
Aug 23, 2024

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Aug 23, 2024

This was partially fixed in #153787, which added just the extension-safe simulator dSYM, but we also bundle:

  • arm64 release dSYM
  • arm64 release extension-safe dSYM
  • arm64_x86_64 simulator dSYM

In a followup engine patch, we'll stop bundling both the regular and extension-safe simulator dSYMs, but this gets the test passing at tip-of-tree.

Issue: #116493

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
iOS: Update codesigned binaries list to match cache
17d136b 
This was partially fixed in flutter#153787, which added just the
extension-safe simulator dSYM, but we also bundle:
* arm64 release dSYM
* arm64 release extension-safe dSYM
* arm64_x86_64 simulator dSYM

In a followup engine patch, we'll stop bundling both the regular and
extension-safe simulator dSYMs, but this gets the test passing at
tip-of-tree.

Issue: flutter#116493
@jmagman jmagman mentioned this pull request Aug 23, 2024
Open
@jmagman
Copy link
Member

jmagman commented Aug 23, 2024

In #153787 @itsjustkevin said:

Is it possible that the test failed only on the first binary?

Sounds like the answer was yes. Did this ever pass on the release branch? Or was the test ignored because we knew it was missing things?
Filed #154029 so this doesn't happen again.

christopherfujino
christopherfujino approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2024
@auto-submit auto-submit bot merged commit 74e2504 into flutter:master Aug 23, 2024
@cbracken cbracken deleted the fix-codesign-binaries-list branch August 23, 2024 21:48
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 24, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
19b6a8b 
…flutter#154027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 24, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
33bfbb9 
…flutter#154027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 25, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
f941ef8 
…flutter#154027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
5c8feda 
…flutter#154027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
71b3eed 
…flutter#154027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
777731c 
…flutter#154027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
4be05bd 
…flutter#154027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
e66ba34 
…flutter#154027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
dad4bb7 
…flutter#154027)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
3bddf41 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
23c1f0b 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
9c1d277 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
d2368cd 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
5c541a8 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
bcef29f 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
575b773 
…flutter#154027)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@cbracken @Buchimi
iOS: Update codesigned binaries list to match cache (flutter#154027)
ff1fdbf 
This was partially fixed in flutter#153787, which added just the extension-safe simulator dSYM, but we also bundle:

* arm64 release dSYM
* arm64 release extension-safe dSYM
* arm64_x86_64 simulator dSYM

In a followup engine patch, we'll stop bundling both the regular and extension-safe simulator dSYMs, but this gets the test passing at tip-of-tree.

Issue: flutter#116493
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
d29ddc2 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
bf2b4d2 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
88a27de 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
6d46bb5 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
086055c 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
d66822e 
…flutter#154027)
cbracken added a commit to cbracken/flutter that referenced this pull request Sep 3, 2024
@cbracken
[CP] Add iOS dSYMs to codesign test
235997b 
In flutter/engine#54414, we added dSYM files for physical and simulator binaries in both regular and extension-safe framework builds. In flutter/engine#54576 we added the dSYMs to the without_entitlements.txt list.

The `dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart` test was updated to reflect these changes in:
* flutter#153787
* flutter#154027

This cherrypicks these two changes to the release branch.

Issue: flutter#116493
@cbracken cbracken mentioned this pull request Sep 3, 2024
Merged
9 tasks
auto-submit bot pushed a commit that referenced this pull request Sep 3, 2024
@cbracken
[CP] Add iOS dSYMs to codesign test (#154582)
4cf269e 
In flutter/engine#54414, we added dSYM files for physical and simulator binaries in both regular and extension-safe framework builds. In flutter/engine#54576 we added the dSYMs to the without_entitlements.txt list.

The `dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart` test was updated to reflect these changes in:
* #153787
* #154027

This cherrypicks these two changes to the release branch.

Issue: #116493
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
82025ba 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
afb99f9 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
af2f686 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
4b44825 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
df396f2 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
6d88e8b 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
a15eb31 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
8b1c412 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
35c6a2e 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
5ec82a7 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
6fa82cc 
…flutter#154027)
Gustl22 pushed a commit to Gustl22/flutter that referenced this pull request Nov 13, 2024
@cbracken @Gustl22
[CP] Add iOS dSYMs to codesign test (flutter#154582)
7aab7c7 
In flutter/engine#54414, we added dSYM files for physical and simulator binaries in both regular and extension-safe framework builds. In flutter/engine#54576 we added the dSYMs to the without_entitlements.txt list.

The `dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart` test was updated to reflect these changes in:
* flutter#153787
* flutter#154027

This cherrypicks these two changes to the release branch.

Issue: flutter#116493
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
f3b540a 
…flutter#154027)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
74e2504 iOS: Update codesigned binaries list to match cache (flutter/…
0cfdf6a 
…flutter#154027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman Awaiting requested review from jmagman

@itsjustkevin itsjustkevin Awaiting requested review from itsjustkevin

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbracken @jmagman @christopherfujino