Add missing tests for `requestFocus` routes parameter in Material and Cupertino libraries #154005

TahaTesser · 2024-08-23T14:19:16Z

Fixes Add missing tests for requestFocus routes parameter

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

… Cupertino libraries

justinmc

LGTM 👍

packages/flutter/test/cupertino/route_test.dart

justinmc · 2024-08-27T21:14:22Z

packages/flutter/test/cupertino/route_test.dart

+    await tester.pump();
+    await tester.pump(const Duration(milliseconds: 100));


Why the two pumps?

This advances the route transition animation by updating the frames and then advancing the animation by 100ms.

Another way to achieve this is to use pumpAndSettle. In some reviews, Hixie preferred this style we know how many frames are pushed to get the results.

I've discussed that with Hixie as well and I agree with this way over pumpAndSettle 👍 . Thanks for the explanation!

Thanks @justinmc. Apologies if i merged it before your reply.

justinmc · 2024-08-27T21:15:42Z

packages/flutter/test/material/dialog_test.dart

    expect(simpleDialog.insetPadding, isNull);
  });

+  // This is a regression test for https://github.com/flutter/flutter/issues/153983.


Did you just remember this?

Added comment for a test added in #154173 when resolving git conflicts.

…rial and Cupertino libraries (flutter/flutter#154005)

… Cupertino libraries (flutter#154005) Fixes [Add missing tests for `requestFocus` routes parameter](flutter#153999)

…rial and Cupertino libraries (flutter/flutter#154005)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. labels Aug 23, 2024

TahaTesser marked this pull request as ready for review August 23, 2024 14:54

TahaTesser requested a review from justinmc August 23, 2024 14:55

TahaTesser mentioned this pull request Aug 23, 2024

The PopupMenuButton should not steal focus from the TextField when it appears. #150568

Merged

9 tasks

Add missing tests for requestFocus routes parameter in Material and…

a62af67

… Cupertino libraries

TahaTesser force-pushed the request_focus_routes_tests branch from ff8b6a3 to a62af67 Compare August 27, 2024 15:48

justinmc approved these changes Aug 27, 2024

View reviewed changes

Add comment

c9b878e

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2024

auto-submit bot merged commit d147e52 into flutter:master Aug 28, 2024

TahaTesser deleted the request_focus_routes_tests branch August 28, 2024 18:46

engine-flutter-autoroll mentioned this pull request Aug 28, 2024

Roll Flutter from b8f89f70bf4e to d147e52d6ae0 (96 revisions) flutter/packages#7530

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 28, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

16c8915

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll mentioned this pull request Aug 29, 2024

Roll Flutter from b8f89f70bf4e to f0860d83f550 (109 revisions) flutter/packages#7532

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

abec081

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll mentioned this pull request Aug 29, 2024

Roll Flutter from b8f89f70bf4e to d01b9a4f8c11 (110 revisions) flutter/packages#7533

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

ca999d9

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll mentioned this pull request Aug 29, 2024

Roll Flutter from b8f89f70bf4e to 911f2ff923c8 (111 revisions) flutter/packages#7534

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

c688473

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll mentioned this pull request Aug 29, 2024

Roll Flutter from b8f89f70bf4e to f9351fae7e75 (112 revisions) flutter/packages#7535

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

6cfc4b3

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll mentioned this pull request Aug 29, 2024

Roll Flutter from b8f89f70bf4e to 9bf7d7bb35b5 (114 revisions) flutter/packages#7536

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

b83ccfb

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll mentioned this pull request Aug 29, 2024

Roll Flutter from b8f89f70bf4e to 48b7a5a38fb9 (115 revisions) flutter/packages#7538

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

513d1a7

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll mentioned this pull request Aug 29, 2024

Roll Flutter from b8f89f70bf4e to 7806c796ac56 (116 revisions) flutter/packages#7539

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

80e7c1d

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll mentioned this pull request Aug 30, 2024

Roll Flutter from b8f89f70bf4e to e48a45ff5e41 (139 revisions) flutter/packages#7554

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

89c3574

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll mentioned this pull request Aug 30, 2024

Roll Flutter from b8f89f70bf4e to 01e8ecaea608 (140 revisions) flutter/packages#7555

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

c9925aa

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll mentioned this pull request Aug 30, 2024

Roll Flutter from b8f89f70bf4e to 0d8247eb7d9f (141 revisions) flutter/packages#7556

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

26d5e54

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

28e8b8a

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

eba5155

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

8c4e146

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

484a395

…rial and Cupertino libraries (flutter/flutter#154005)

Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024

Add missing tests for requestFocus routes parameter in Material and…

56c44cf

… Cupertino libraries (flutter#154005) Fixes [Add missing tests for `requestFocus` routes parameter](flutter#153999)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

fbd04c7

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

60c9b38

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

13964eb

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

9fe5146

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

1740d0f

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

fc01cf0

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

f5bb6f1

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

de60006

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

d77f7a1

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

c0fe1dc

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

8e75c17

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

ada586e

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

d09c756

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

06ae1cb

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

91f288c

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

48d1b20

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

ddd2bbd

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

58b726d

…rial and Cupertino libraries (flutter/flutter#154005)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

d147e52 Add missing tests for requestFocus routes parameter in Mate…

186fd63

…rial and Cupertino libraries (flutter/flutter#154005)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add missing tests for `requestFocus` routes parameter in Material and Cupertino libraries #154005

Add missing tests for `requestFocus` routes parameter in Material and Cupertino libraries #154005

Uh oh!

TahaTesser commented Aug 23, 2024

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

justinmc Aug 27, 2024

Uh oh!

TahaTesser Aug 28, 2024 •

edited

Loading

Uh oh!

justinmc Aug 29, 2024

Uh oh!

TahaTesser Aug 29, 2024

Uh oh!

justinmc Aug 27, 2024

Uh oh!

TahaTesser Aug 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		await tester.pump();
		await tester.pump(const Duration(milliseconds: 100));

Add missing tests for requestFocus routes parameter in Material and Cupertino libraries #154005

Add missing tests for requestFocus routes parameter in Material and Cupertino libraries #154005

Uh oh!

Conversation

TahaTesser commented Aug 23, 2024

Pre-launch Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinmc Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

TahaTesser Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

TahaTesser Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

TahaTesser Aug 28, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add missing tests for `requestFocus` routes parameter in Material and Cupertino libraries #154005

Add missing tests for `requestFocus` routes parameter in Material and Cupertino libraries #154005

TahaTesser Aug 28, 2024 •

edited

Loading