macOS: Copy macOS framework dSYM into build outputs #153975

cbracken · 2024-08-22T22:49:36Z

As of Xcode 16, App Store validation now requires that apps uploaded to the App store bundle dSYM debug information bundles for each Framework they embed.

dSYM bundles are packaged in the FlutterMacOS.xcframework shipped in the darwin-x64-release tools archive as of engine patches:

macOS: Bundle dSYM packages in FlutterMacOS.xcframework engine#54696

This copies the FlutterMacOS.framework.dSYM bundle from the tools cache to the build outputs produced by flutter build macOS.

Fixes: #153879

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter_tools/lib/src/artifacts.dart

packages/flutter_tools/lib/src/build_system/targets/macos.dart

packages/flutter_tools/lib/src/artifacts.dart

packages/flutter_tools/lib/src/build_system/targets/macos.dart

packages/flutter_tools/test/general.shard/build_system/targets/macos_test.dart

dev/integration_tests/flutter_gallery/macos/Podfile.lock

jmagman · 2024-08-23T18:21:28Z

packages/flutter_tools/lib/src/build_system/targets/macos.dart

+    await super.build(environment);
+
+    // Copy Flutter framework dSYM (debug symbol) bundle, if present.
+    final String? buildModeEnvironment = environment.defines[kBuildMode];


I'm guessing yes because it's not being copied into the app, but this is safe to do post-codesigning the framework, right?

Yep -- this is just copying the already signed-by-us dSYM as a sibling into the same output directory, not embedding in any container. Both the app bundle and the App dSYM later get embedded into the xcarchive, but that's a separate step currently handled by Xcode. As is, those archives pass app validation in manual testing.

As of Xcode 16, App Store validation now requires that apps uploaded to the App store bundle dSYM debug information bundles for each Framework they embed. dSYM bundles are packaged in the FlutterMacOS.xcframework shipped in the `darwin-x64-release` tools archive as of engine patches: * flutter/engine#54696 This copies the FlutterMacOS.framework.dSYM bundle from the tools cache to the build outputs produced by `flutter build macos`. Issue: https://github.com/flutter/flutter/issue/153879

Also use const to do concatenation at compile time.

auto-submit · 2024-08-23T23:34:12Z

auto label is removed for flutter/flutter/153975, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

cbracken · 2024-08-24T00:14:37Z

Verified presubmits on cl/666904278 and they had passed.

…lutter#153975)

As of Xcode 16, App Store validation now requires that apps uploaded to the App store bundle dSYM debug information bundles for each Framework they embed. dSYM bundles are packaged in the FlutterMacOS.xcframework shipped in the `darwin-x64-release` tools archive as of engine patches: * flutter/engine#54696 This copies the FlutterMacOS.framework.dSYM bundle from the tools cache to the build outputs produced by `flutter build macOS`. Fixes: flutter#153879

…lutter#153975)

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. engine flutter/engine related. See also e: labels. labels Aug 22, 2024

cbracken requested a review from jmagman August 22, 2024 22:49

cbracken force-pushed the copy-macos-dsym branch from 643924e to c415a44 Compare August 22, 2024 22:54

github-actions bot removed the engine flutter/engine related. See also e: labels. label Aug 22, 2024

cbracken commented Aug 22, 2024

View reviewed changes

packages/flutter_tools/lib/src/artifacts.dart Show resolved Hide resolved

cbracken mentioned this pull request Aug 22, 2024

[macOS] Embed dSYM in release FlutterMacOS.xcframework #153879

Closed

6 tasks

jmagman reviewed Aug 22, 2024

View reviewed changes

cbracken force-pushed the copy-macos-dsym branch 2 times, most recently from 4f48183 to 31f868c Compare August 23, 2024 17:49

github-actions bot added the a: desktop Running on desktop label Aug 23, 2024

jmagman reviewed Aug 23, 2024

View reviewed changes

dev/integration_tests/flutter_gallery/macos/Podfile.lock Outdated Show resolved Hide resolved

jmagman reviewed Aug 23, 2024

View reviewed changes

cbracken force-pushed the copy-macos-dsym branch from d68bc17 to 296994b Compare August 23, 2024 18:27

github-actions bot removed the a: desktop Running on desktop label Aug 23, 2024

jmagman approved these changes Aug 23, 2024

View reviewed changes

cbracken added 3 commits August 23, 2024 12:06

Move dSYM copy to ReleaseUnpackMacOS

f6a2a36

Also use const to do concatenation at compile time.

Remove unnecessary const

77b4b14

cbracken force-pushed the copy-macos-dsym branch 2 times, most recently from 0bd8dc9 to 942d191 Compare August 23, 2024 20:01

Add test for framework dSYM in xcframework and built app

85f1d43

cbracken force-pushed the copy-macos-dsym branch from 942d191 to 85f1d43 Compare August 23, 2024 20:26

cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2024

cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2024

auto-submit bot merged commit 11ab37e into flutter:master Aug 24, 2024

cbracken deleted the copy-macos-dsym branch August 24, 2024 00:14

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

cbcdc10

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

adf1dde

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

3d7290b

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

9e773b2

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

d7db94d

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

0b7df7f

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

9f13370

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

8fb68b4

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

fedb9e5

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

35c5216

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

0c288ae

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

e792771

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

b9d2534

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

a767707

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

a106397

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

da3619f

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

7602f4c

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

9cd7f06

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

d7139a1

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

50f7ecb

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

6d982d2

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

7796ee7

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

ee29aad

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

ce25fa9

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

de16874

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

464ffc1

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

7a691ce

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

d937df7

…lutter#153975)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

11ab37e macOS: Copy macOS framwork dSYM into build outputs (flutter/f…

eb943c3

…lutter#153975)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

macOS: Copy macOS framework dSYM into build outputs #153975

macOS: Copy macOS framework dSYM into build outputs #153975

Uh oh!

cbracken commented Aug 22, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmagman Aug 23, 2024

Uh oh!

cbracken Aug 23, 2024 •

edited

Loading

Uh oh!

auto-submit bot commented Aug 23, 2024

Uh oh!

cbracken commented Aug 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

macOS: Copy macOS framework dSYM into build outputs #153975

macOS: Copy macOS framework dSYM into build outputs #153975

Uh oh!

Conversation

cbracken commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmagman Aug 23, 2024

Choose a reason for hiding this comment

Uh oh!

cbracken Aug 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Aug 23, 2024

Uh oh!

cbracken commented Aug 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cbracken commented Aug 22, 2024 •

edited

Loading

cbracken Aug 23, 2024 •

edited

Loading