[CP-stable][native_assets] Fix macOS host build failure when there are no frameworks to sign. #153967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orks to sign. (flutter#150742) When the `"${native_assets_path}"*.framework` glob doesn't resolve anything, the bash will run the loop once with the original unglobbed value: `/path/to/native/assets/*.framework`. Skip this case to prevent the build from failing when there are no frameworks to sign. To reproduce this build failure: 1. Enable native assets in the Flutter tool: `flutter config --enable-native-assets` 2. Create a Flutter project with the default template: `flutter create test_native_assets` 3. Add a build hook that does nothing (`hook/build.dart`). 4. Try to build/run the app: `flutter run --debug -d macos`
Author
|
@jmagman please fill out the PR description above, afterwards the release team will review this request. |
github-actions
bot
added
the
tool
Member
|
@bdero would you mind double-checking the cherry-pick template PR description? Did I misrepresent anything? Feel free to edit. |
Member
|
@jmagman LGTM, thanks 👍 |
zanderso
approved these changes
Aug 24, 2024
Member
|
CP lgtm |
reidbaker
approved these changes
Aug 26, 2024
reidbaker
added
the
autosubmit
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
# Flutter stable 3.24.0 Framework ## Scheduled Cherrypicks [flutter/153949](#153949): Fix a crash when deleting text inside CupertinoPageRoute, with a CJK (chinese, japanese, korean) keyboard on Android. [flutter/153939](#153939): Fixes an issue where Flutter TextField may stop accepting input on iOS. [flutter/152420](#152420): Fixes scrolling jank when a SelectionArea/SelectableRegion is used as a child of a Scrollable like ListView or PageView on Android and iOS. [flutter/154199](#154199): Removes log spam when building a freshly created template app for Android. [flutter/153967](#153967): Fixes macOS host build failure when there are no native asset frameworks to codesign. Impacts users who have enabled experimental native assets feature. [flutter/153769](#153769): When running a Flutter app, display a concise error message when connection to the device is lost. [flutter/154270](#154270): Prevent preemptive gradle crash for android builds that would fail to build anyway but with a confusing error message. [flutter/54735](flutter/engine#54735): When semantics are enabled on Web, the onTap of various widgets (GestureDetector, InkWell) are called twice or the callback from one widget is called when another widget is pressed.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…there are no frameworks to sign. (flutter/flutter#153967)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…there are no frameworks to sign. (flutter/flutter#153967)
Gustl22
pushed a commit
to Gustl22/flutter
that referenced
this pull request
Nov 13, 2024
…er#154430) # Flutter stable 3.24.0 Framework ## Scheduled Cherrypicks [flutter/153949](flutter#153949): Fix a crash when deleting text inside CupertinoPageRoute, with a CJK (chinese, japanese, korean) keyboard on Android. [flutter/153939](flutter#153939): Fixes an issue where Flutter TextField may stop accepting input on iOS. [flutter/152420](flutter#152420): Fixes scrolling jank when a SelectionArea/SelectableRegion is used as a child of a Scrollable like ListView or PageView on Android and iOS. [flutter/154199](flutter#154199): Removes log spam when building a freshly created template app for Android. [flutter/153967](flutter#153967): Fixes macOS host build failure when there are no native asset frameworks to codesign. Impacts users who have enabled experimental native assets feature. [flutter/153769](flutter#153769): When running a Flutter app, display a concise error message when connection to the device is lost. [flutter/154270](flutter#154270): Prevent preemptive gradle crash for android builds that would fail to build anyway but with a confusing error message. [flutter/54735](flutter/engine#54735): When semantics are enabled on Web, the onTap of various widgets (GestureDetector, InkWell) are called twice or the callback from one widget is called when another widget is pressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link:
#153842
(also duplicate #153268)
Changelog Description:
Fixes macOS host build failure when there are no native asset frameworks to codesign
Impact Description:
macOS apps may fail to build with the error:
*.framework: No such file or directory.Workaround:
flutter cleantemporarily unwedged them.Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
From PR #150742
To reproduce this build failure:
flutter config --enable-native-assetsflutter create test_native_assetshook/build.dart).flutter run --debug -d macosExpect the build to succeed.