Switched CupertinoDynamicColor to `implements Color` #153938

gaaclarke · 2024-08-22T15:54:43Z

issue: #127855
This was an impediment to changing the Color class.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-08-22T15:54:46Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gaaclarke · 2024-08-22T15:55:29Z

packages/flutter/lib/src/cupertino/colors.dart

-  ) : // The super constructor has to be called with a dummy value in order to mark
-      // this constructor const.
-      // The field `value` is overridden in the class implementation.
-      super(0);


gaaclarke · 2024-08-22T16:01:42Z

There are a couple of other places where we sublcass Color but they aren't making any assumptions about how Color is implemented so I'm going to try leaving them.

gaaclarke · 2024-08-22T16:46:56Z

I'm dropping this back into a draft, we are going to land this after flutter/engine#54415

goderbauer

LGTM

issue: flutter/flutter#127855 integration test: #54415 This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8 The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this: 1) Land this PR 1) Wait for it to roll into the Framework 1) Land flutter/flutter#153938 which will make CupertinoDynamicColor implement Color 1) Land another engine PR that rips out the int storage: #54714 Here are follow up PRs: 1) #54473 - changes DlColor so the wide gamut colors are rendered 1) #54567 - Hooks up these changes to take advantage of wide DlColor 1) flutter/flutter#153319 - the integration test for the framework repo There are some things that have been left as follow up PRs since they are technically breaking: 1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth 1) `operator==` hasn't been updated to take advantage of the higher bit depth 1) `hashCode` hasn't been updated to take advantage of the higher bit depth 1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth 1) `toString` hasn't been updated to take advantage of the higher bit depth ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

issue: flutter/flutter#127855 integration test: flutter#54415 This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8 The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this: 1) Land this PR 1) Wait for it to roll into the Framework 1) Land flutter/flutter#153938 which will make CupertinoDynamicColor implement Color 1) Land another engine PR that rips out the int storage: flutter#54714 Here are follow up PRs: 1) flutter#54473 - changes DlColor so the wide gamut colors are rendered 1) flutter#54567 - Hooks up these changes to take advantage of wide DlColor 1) flutter/flutter#153319 - the integration test for the framework repo There are some things that have been left as follow up PRs since they are technically breaking: 1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth 1) `operator==` hasn't been updated to take advantage of the higher bit depth 1) `hashCode` hasn't been updated to take advantage of the higher bit depth 1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth 1) `toString` hasn't been updated to take advantage of the higher bit depth ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

[This PR](#54415) was reverted because it requires a manual roll into the framework. issue: flutter/flutter#127855 integration test: #54415 This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8 The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this: 1) Land this PR 1) Wait for it to roll into the Framework 1) Land flutter/flutter#153938 which will make CupertinoDynamicColor implement Color 1) Land another engine PR that rips out the int storage: #54714 Here are follow up PRs: 1) #54473 - changes DlColor so the wide gamut colors are rendered 1) #54567 - Hooks up these changes to take advantage of wide DlColor 1) flutter/flutter#153319 - the integration test for the framework repo There are some things that have been left as follow up PRs since they are technically breaking: 1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth 1) `operator==` hasn't been updated to take advantage of the higher bit depth 1) `hashCode` hasn't been updated to take advantage of the higher bit depth 1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth 1) `toString` hasn't been updated to take advantage of the higher bit depth

gaaclarke · 2024-08-29T22:54:18Z

Now that flutter/engine#54737 has landed and rolled into the framework this will require updating before landed. I'll do that tomorrow.

Reverts: #54737 Initiated by: chingjun Reason for reverting: Breaking internal tests. See b/363125155 Original PR Author: gaaclarke Reviewed By: {matanlurey, jonahwilliams} This change reverts the following previous change: [This PR](#54415) was reverted because it requires a manual roll into the framework. issue: flutter/flutter#127855 integration test: #54415 This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8 The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this: 1) Land this PR 1) Wait for it to roll into the Framework 1) Land flutter/flutter#153938 which will make CupertinoDynamicColor implement Color 1) Land another engine PR that rips out the int storage: #54714 Here are follow up PRs: 1) #54473 - changes DlColor so the wide gamut colors are rendered 1) #54567 - Hooks up these changes to take advantage of wide DlColor 1) flutter/flutter#153319 - the integration test for the framework repo There are some things that have been left as follow up PRs since they are technically breaking: 1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth 1) `operator==` hasn't been updated to take advantage of the higher bit depth 1) `hashCode` hasn't been updated to take advantage of the higher bit depth 1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth 1) `toString` hasn't been updated to take advantage of the higher bit depth

[This PR](flutter#54415) was reverted because it requires a manual roll into the framework. issue: flutter/flutter#127855 integration test: flutter#54415 This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8 The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this: 1) Land this PR 1) Wait for it to roll into the Framework 1) Land flutter/flutter#153938 which will make CupertinoDynamicColor implement Color 1) Land another engine PR that rips out the int storage: flutter#54714 Here are follow up PRs: 1) flutter#54473 - changes DlColor so the wide gamut colors are rendered 1) flutter#54567 - Hooks up these changes to take advantage of wide DlColor 1) flutter/flutter#153319 - the integration test for the framework repo There are some things that have been left as follow up PRs since they are technically breaking: 1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth 1) `operator==` hasn't been updated to take advantage of the higher bit depth 1) `hashCode` hasn't been updated to take advantage of the higher bit depth 1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth 1) `toString` hasn't been updated to take advantage of the higher bit depth

[This PR](#54415) was reverted because it required customer testing updates. issue: flutter/flutter#127855 integration test: #54415 This does the preliminary work for implementing wide gamut colors in the Flutter framework. Here are the following changes: 1) colors now specify a colorspace with which they are to be interpreted 1) colors now store their components as floats to accommodate bit depths more than 8 The storage of this Color class is weird with float/int storage but that is a temporary solution to support a smooth transition. Here is the plan for landing this: 1) Land this PR 1) Wait for it to roll into the Framework 1) Land flutter/flutter#153938 which will make CupertinoDynamicColor implement Color 1) Land another engine PR that rips out the int storage: #54714 Here are follow up PRs: 1) #54473 - changes DlColor so the wide gamut colors are rendered 1) #54567 - Hooks up these changes to take advantage of wide DlColor 1) flutter/flutter#153319 - the integration test for the framework repo There are some things that have been left as follow up PRs since they are technically breaking: 1) The math on `lerp` hasn't been updated to take advantage of the higher bit depth 1) `operator==` hasn't been updated to take advantage of the higher bit depth 1) `hashCode` hasn't been updated to take advantage of the higher bit depth 1) `alphaBlend` hasn't been updated to take advantage of the higher bit depth 1) `toString` hasn't been updated to take advantage of the higher bit depth ## Reland 2 notes This was reverted because it changes the math on `_lerpDouble`. While those changes were mathematcially equivalent, they had different behaviors when working with non-numbers which created unexpected changes. The change has been reverted and a test added. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

gaaclarke · 2024-08-30T22:48:02Z

This seems to be failing in google testing since the changes to Color haven't rolled into google3 yet.

…/flutter#153938)

…/flutter#153938)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Aug 22, 2024

gaaclarke commented Aug 22, 2024

View reviewed changes

gaaclarke requested review from goderbauer and jonahwilliams August 22, 2024 15:55

gaaclarke marked this pull request as draft August 22, 2024 16:47

gaaclarke mentioned this pull request Aug 22, 2024

Framework wide color flutter/engine#54415

Merged

8 tasks

goderbauer approved these changes Aug 22, 2024

View reviewed changes

gaaclarke mentioned this pull request Aug 22, 2024

Removes the int storage from Color flutter/engine#54714

Merged

8 tasks

gaaclarke mentioned this pull request Aug 23, 2024

Reland: Framework wide color (#54415) flutter/engine#54737

Merged

8 tasks

gaaclarke marked this pull request as ready for review August 29, 2024 22:53

gaaclarke force-pushed the implements-color branch from dea2867 to 46a40bd Compare August 29, 2024 22:53

gaaclarke marked this pull request as draft August 29, 2024 22:53

auto-submit bot mentioned this pull request Aug 30, 2024

Reverts "Reland: Framework wide color (#54415) (#54737)" flutter/engine#54885

Merged

8 tasks

gaaclarke mentioned this pull request Aug 30, 2024

Reland: Framework wide color (#54415) (#54737) flutter/engine#54905

Merged

8 tasks

gaaclarke force-pushed the implements-color branch from 46a40bd to 10d1160 Compare August 30, 2024 20:17

gaaclarke marked this pull request as ready for review August 30, 2024 20:32

Removed extending Color

73fb141

updated implements

3239f67

gaaclarke force-pushed the implements-color branch from 051eab3 to 3239f67 Compare September 3, 2024 16:44

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2024

auto-submit bot merged commit 52bb0c4 into flutter:master Sep 3, 2024

engine-flutter-autoroll mentioned this pull request Sep 4, 2024

Roll Flutter from b8f89f70bf4e to a5ca16ea9404 (185 revisions) flutter/packages#7576

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

52bb0c4 Switched CupertinoDynamicColor to implements Color (flutter…

2849959

…/flutter#153938)

engine-flutter-autoroll mentioned this pull request Sep 4, 2024

Roll Flutter from b8f89f70bf4e to 4a54ca828583 (186 revisions) flutter/packages#7577

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

52bb0c4 Switched CupertinoDynamicColor to implements Color (flutter…

8c1a155

…/flutter#153938)

engine-flutter-autoroll mentioned this pull request Sep 4, 2024

Roll Flutter from b8f89f70bf4e to 40f763aeaa0b (187 revisions) flutter/packages#7579

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

52bb0c4 Switched CupertinoDynamicColor to implements Color (flutter…

0ea96ee

…/flutter#153938)

engine-flutter-autoroll mentioned this pull request Sep 4, 2024

Roll Flutter from b8f89f70bf4e to 056c40f55b2c (188 revisions) flutter/packages#7580

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

52bb0c4 Switched CupertinoDynamicColor to implements Color (flutter…

d259ca2

…/flutter#153938)

engine-flutter-autoroll mentioned this pull request Sep 4, 2024

Roll Flutter from b8f89f70bf4e to d9dda9d08fc3 (189 revisions) flutter/packages#7581

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

52bb0c4 Switched CupertinoDynamicColor to implements Color (flutter…

98b44cd

…/flutter#153938)

engine-flutter-autoroll mentioned this pull request Sep 4, 2024

Roll Flutter from b8f89f70bf4e to 4e8df8be3148 (192 revisions) flutter/packages#7582

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

52bb0c4 Switched CupertinoDynamicColor to implements Color (flutter…

11bd402

…/flutter#153938)

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to a7cd788d80cc (201 revisions) flutter/packages#7584

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

52bb0c4 Switched CupertinoDynamicColor to implements Color (flutter…

4d371dc

…/flutter#153938)

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to 45ef8f36ff41 (202 revisions) flutter/packages#7585

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

52bb0c4 Switched CupertinoDynamicColor to implements Color (flutter…

594fffd

…/flutter#153938)

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to a3301cecae28 (203 revisions) flutter/packages#7588

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

52bb0c4 Switched CupertinoDynamicColor to implements Color (flutter…

530650e

…/flutter#153938)

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to 834566f05d36 (204 revisions) flutter/packages#7589

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

52bb0c4 Switched CupertinoDynamicColor to implements Color (flutter…

4b6df9e

…/flutter#153938)

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to fea5d1ec0394 (205 revisions) flutter/packages#7590

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

52bb0c4 Switched CupertinoDynamicColor to implements Color (flutter…

e886abe

…/flutter#153938)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

52bb0c4 Switched CupertinoDynamicColor to implements Color (flutter…

675aebb

…/flutter#153938)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

52bb0c4 Switched CupertinoDynamicColor to implements Color (flutter…

c51091c

…/flutter#153938)

ksokolovskyi mentioned this pull request Jun 24, 2025

CupertinoDynamicColor is missing deprecation notices. #171059

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Switched CupertinoDynamicColor to `implements Color` #153938

Switched CupertinoDynamicColor to `implements Color` #153938

Uh oh!

gaaclarke commented Aug 22, 2024

Uh oh!

flutter-dashboard bot commented Aug 22, 2024

Uh oh!

gaaclarke Aug 22, 2024

Uh oh!

gaaclarke commented Aug 22, 2024

Uh oh!

gaaclarke commented Aug 22, 2024

Uh oh!

goderbauer left a comment

Uh oh!

gaaclarke commented Aug 29, 2024

Uh oh!

gaaclarke commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Switched CupertinoDynamicColor to implements Color #153938

Switched CupertinoDynamicColor to implements Color #153938

Uh oh!

Conversation

gaaclarke commented Aug 22, 2024

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Aug 22, 2024

Uh oh!

gaaclarke Aug 22, 2024

Choose a reason for hiding this comment

Uh oh!

gaaclarke commented Aug 22, 2024

Uh oh!

gaaclarke commented Aug 22, 2024

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

gaaclarke commented Aug 29, 2024

Uh oh!

gaaclarke commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Switched CupertinoDynamicColor to `implements Color` #153938

Switched CupertinoDynamicColor to `implements Color` #153938