Skip to content

Fix flutter test in workspace #153919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sigurdm merged 4 commits into from
Aug 22, 2024
Merged

Fix flutter test in workspace #153919

sigurdm merged 4 commits into from
Aug 22, 2024

Conversation

@sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Aug 22, 2024

Follow-up to #153754.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 22, 2024
sigurdm
sigurdm commented Aug 22, 2024
View reviewed changes
packages/flutter_tools/lib/src/commands/test.dart
// workspaces.
final int build = await assetBundle.build(
packageConfigPath: '.dart_tool/package_config.json',
packageConfigPath: packageConfigPath,
Copy link
Contributor Author

@sigurdm sigurdm Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry - you pointed this mistake out already in the original review.

I think I confused the context somehow, and thought this was a util for the flutter_tools tests, not the test command itself.

andrewkolos
andrewkolos approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe other references to .dart_tool/package_config.json should be checked out as well. I see a few in packages/flutter_tools/lib/src/build_system/targets/web.dart and packages/flutter_tools/lib/src/isolated/native_assets/native_assets.dart.

@sigurdm
Copy link
Contributor Author

sigurdm commented Aug 22, 2024

I see a few in packages/flutter_tools/lib/src/build_system/targets/web.dart and packages/flutter_tools/lib/src/isolated/native_assets/native_assets.dart.

Yeah native_assets was broken as well. I think packages/flutter_tools/lib/src/build_system/targets/web.dart is ok.

I did a few extra fixes.

@sigurdm sigurdm merged commit dfdd5f8 into flutter:master Aug 22, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
157f664
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
ce3e5d7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
fe4da0c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
934346e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
2f3722b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
d07705c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
2e983bd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
5a67cd5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
f3a2116
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
00674d5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
e5cdf00
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
c0bf998
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
c260b30
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
4861a88
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
de1f9a2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
bf5f945
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
03c0519
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
3d54cae
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
5e7993b
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@sigurdm @Buchimi
Fix flutter test in workspace (flutter#153919)
cebb29a 
Follow-up to flutter#153754.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
c6748d4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
b112783
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
254d29d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
e927940
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
2a32114
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
66e40d3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
f0d2af5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
7bb4255
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
0f1f6ae
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
bd7ab7f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
02dad10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
2eb1537
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
19f7dc6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
b87f348
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
eec9d89
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
5c94191
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
1d48608
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
45d6f4c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
dfdd5f8 Fix flutter test in workspace (flutter/flutter#153919)
c45901f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkolos andrewkolos andrewkolos approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sigurdm @andrewkolos