Reverts "Roll Flutter Engine from b94e0097035d to f493c212c23e (18 revisions) (#153884)" #153899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
fluttergithubbot
approved these changes
Aug 22, 2024
auto-submit
bot
deleted the
revert_9a74329c15119078d38dec3e50a0e63e0364a49a
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 22, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 22, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 22, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 22, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 22, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 22, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 23, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 31, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 31, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 1, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…visions) (flutter#153884)" (flutter#153899) Reverts: flutter#153884 Initiated by: jason-simmons Reason for reverting: flutter/engine@f8d553a introduced a log message that is not expected by the `run_debug_test_android` devicelab test Reverting until an engine build is available with the log removed (see flutter/engine#54699) Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@b94e009...f493c21 2024-08-21 [email protected] [iOS] Tweak note about OpenGL support on mac in a user facing log. (flutter/engine#54690) 2024-08-21 [email protected] [Impeller] use blit pass to resize decoded images. (flutter/engine#54606) 2024-08-21 [email protected] Remove spammy warning message on `FlutterView` (flutter/engine#54686) 2024-08-21 [email protected] [Impeller] Perform integrity checks for Vulkan pipeline caches. (flutter/engine#54654) 2024-08-21 [email protected] docs: use test: all rather than editing .ci.yaml (flutter/engine#54667) 2024-08-21 [email protected] Reland "[DisplayList] Allow random access to ops through indexing" (flutter/engine#54676) 2024-08-21 [email protected] Roll Skia from 51ac9d93850c to 249d3f07c4d5 (2 revisions) (flutter/engine#54684) 2024-08-21 [email protected] iOS,macOS: Don't archive extra framework metadata (flutter/engine#54674) 2024-08-21 [email protected] Roll Dart SDK from 48f9b96d71e7 to 060e40916514 (1 revision) (flutter/engine#54682) 2024-08-21 [email protected] [web] annotate obscured text fields as passwords (flutter/engine#54664) 2024-08-21 [email protected] Roll Skia from c31e2ca59bd9 to 51ac9d93850c (2 revisions) (flutter/engine#54681) 2024-08-21 [email protected] [engine] reland weaken affinity of raster/ui to non-e core instead of only fast core (flutter/engine#54616) 2024-08-21 [email protected] Roll Skia from c00866df101a to c31e2ca59bd9 (2 revisions) (flutter/engine#54680) 2024-08-21 [email protected] Roll Skia from 39e5118034f4 to c00866df101a (1 revision) (flutter/engine#54678) 2024-08-21 [email protected] Roll Skia from 221ada80b174 to 39e5118034f4 (1 revision) (flutter/engine#54677) 2024-08-21 [email protected] Roll Skia from d576296091e0 to 221ada80b174 (2 revisions) (flutter/engine#54675) 2024-08-21 [email protected] Roll Dart SDK from 49f655b526c7 to 48f9b96d71e7 (1 revision) (flutter/engine#54672) 2024-08-21 [email protected] Roll Fuchsia Linux SDK from 3a16kOsyFmJh3lo7e... to XGzE3idakwfQZ68pb... (flutter/engine#54671) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 3a16kOsyFmJh to XGzE3idakwfQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
…e (18 revisions) (#153884)" (flutter/flutter#153899)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #153884
Initiated by: jason-simmons
Reason for reverting: flutter/engine@f8d553a introduced a log message that is not expected by the
run_debug_test_androiddevicelab testReverting until an engine build is available with the log removed (see flutter/engine#54699)
Original PR Author: engine-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
flutter/engine@b94e009...f493c21
2024-08-21 [email protected] [iOS] Tweak note about OpenGL support on mac in a user facing log. (flutter/engine#54690)
2024-08-21 [email protected] [Impeller] use blit pass to resize decoded images. (flutter/engine#54606)
2024-08-21 [email protected] Remove spammy warning message on
FlutterView(flutter/engine#54686)2024-08-21 [email protected] [Impeller] Perform integrity checks for Vulkan pipeline caches. (flutter/engine#54654)
2024-08-21 [email protected] docs: use test: all rather than editing .ci.yaml (flutter/engine#54667)
2024-08-21 [email protected] Reland "[DisplayList] Allow random access to ops through indexing" (flutter/engine#54676)
2024-08-21 [email protected] Roll Skia from 51ac9d93850c to 249d3f07c4d5 (2 revisions) (flutter/engine#54684)
2024-08-21 [email protected] iOS,macOS: Don't archive extra framework metadata (flutter/engine#54674)
2024-08-21 [email protected] Roll Dart SDK from 48f9b96d71e7 to 060e40916514 (1 revision) (flutter/engine#54682)
2024-08-21 [email protected] [web] annotate obscured text fields as passwords (flutter/engine#54664)
2024-08-21 [email protected] Roll Skia from c31e2ca59bd9 to 51ac9d93850c (2 revisions) (flutter/engine#54681)
2024-08-21 [email protected] [engine] reland weaken affinity of raster/ui to non-e core instead of only fast core (flutter/engine#54616)
2024-08-21 [email protected] Roll Skia from c00866df101a to c31e2ca59bd9 (2 revisions) (flutter/engine#54680)
2024-08-21 [email protected] Roll Skia from 39e5118034f4 to c00866df101a (1 revision) (flutter/engine#54678)
2024-08-21 [email protected] Roll Skia from 221ada80b174 to 39e5118034f4 (1 revision) (flutter/engine#54677)
2024-08-21 [email protected] Roll Skia from d576296091e0 to 221ada80b174 (2 revisions) (flutter/engine#54675)
2024-08-21 [email protected] Roll Dart SDK from 49f655b526c7 to 48f9b96d71e7 (1 revision) (flutter/engine#54672)
2024-08-21 [email protected] Roll Fuchsia Linux SDK from 3a16kOsyFmJh3lo7e... to XGzE3idakwfQZ68pb... (flutter/engine#54671)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 3a16kOsyFmJh to XGzE3idakwfQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md