Skip to content

Conversation

@cbracken
Copy link
Member

Test roll of flutter/engine#54685 "macOS: Make framework creation consistent with iOS"

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Test roll of flutter/engine#54685 "macOS: Make framework creation consistent with iOS"
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Aug 22, 2024
@cbracken cbracken closed this Aug 22, 2024
@cbracken cbracken deleted the test-engine-roll branch August 22, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant